Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report and log management #33

Closed
wants to merge 20 commits into from
Closed

Conversation

F4R0N
Copy link

@F4R0N F4R0N commented Jul 4, 2017

Hi,
I made some change which might be usefull for the current version. A lot of my changes are for our custom usage and not perfectly implemented. It's kinda my first time using github this way and i also only started using it halfway through.

My main changes are in the report and log management. I added an option to edit log entries by clicking on the username seen in the report view. After saving changes you will be sent back to report.php.
We have a team of 5 people who put all there times and infos in but not all of it is actually relevant. So someone has to go over a month worth of information and put some structure into it. By adding a way to edit the log entries on the report page everything gets easier and faster. This might be helpful for other people but you could probably ignore it.

In addition i am replacing commas by dots on the time entry page. The german/european num block uses a comma insted of a point.

Another minor problem was fixed by adding upper(clientname) in an sql statement to make it the same as the other usage.

I also only worked on the german and english translation files.
The favReports still have to be adjusted to the changes i did by adding billable as an option.

F4R0N added 14 commits June 8, 2017 11:22
V1.0

Report
billable added as option in "show fields"
exportable to csv and xml
email not tested yet

Log Management
date is linking to time_edit.php
if user has option to behalf as someone else activeaccount has to be switched to the one who created the log

@todo:
testing
rights?
billable part of invoices?
link back to report.php (time_edit.php)
Search for invoices by date - wip
Reports allows everyone to chose from billable and invoices if plugin "iv" is activated.

Users who can manage the team are able to edit the time log by clicking on the user name in the report.

Duration input now allows ","
Commas will be replaced by a dot in normalizeDuration();
Sort clients by UPPER( client_name ) to have the same order used by  invoice_add.php
trying to make the note data field wider. and start, end and duration thinner.
Report and log management V1.0
V1.0

Report
billable added as option in "show fields"
exportable to csv and xml
email not tested yet

Log Management
date is linking to time_edit.php
if user has option to behalf as someone else activeaccount has to be switched to the one who created the log

@todo:
testing
rights?
billable part of invoices?

-------
Report:

link back to report.php (time_edit.php)

-------

Invoices By Date

Search for invoices by date - wip

-------

report and time(_edit) changes

Reports allows everyone to chose from billable and invoices if plugin "iv" is activated.

Users who can manage the team are able to edit the time log by clicking on the user name in the report.

Duration input now allows ","
Commas will be replaced by a dot in normalizeDuration();

-------

report and invoice: same sorting order
Sort clients by UPPER( client_name ) to have the same order used by invoice_add.php

-------

pdf - trying some style changes

trying to make the note data field wider. and start, end and duration thinner.
Correcting a comment
- adding new sql column for clients (client_number)
- added client number to report
- adding custom csv export
Fixed Bug where client number couldn't be found, because of missing left join.
Left Join now also aplies when chclient_number is chosen.
missing td-tags added
Custom Style Changes
@F4R0N F4R0N closed this Jul 4, 2017
@F4R0N F4R0N reopened this Jul 4, 2017
Copy link
Author

@F4R0N F4R0N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried changing the style in topdf.php a bit. By setting the width of the note, start, end and duration fields to a fixed value. If you select every option for the report it will go out of the page and you won't be able to see some stuff. These changes are made to make the note field easier readable and i failed to get this done another way. So for now i will let it be this way for personal use.
I am still looking for a way to adjust the width of the other columns automatically though.

@anuko
Copy link
Owner

anuko commented Jul 9, 2017

Re: commas. I integrated the change as a separate commit, and will try to review other suggestions over the week or so.

anuko added a commit that referenced this pull request Jul 9, 2017
Possible for everyone by clicking on date
Billable and Clientnumber now also in FavReprot
Updated german language file and added error key for invoiced time entry.
@anuko
Copy link
Owner

anuko commented Jul 15, 2017

I included German corrections in a separate commit. However, I have a question whether form.invoice.invoice_entries is translated correctly. I put some comments into the updated de.lang.php file.

// TODO: check if form.invoice.invoice_entries is translated correctly.
+// This is a label for a dropdown at https://timetracker.anuko.com/invoice_delete.php with 2 options:
+// "delete" and "do not delete".
+// The setting tells whether we are deleting invoiced items when deleting an invoice.
+// If we select "do not delete" then the items stay, and can be included in another invoice.
+'form.invoice.invoice_entries' => 'Rechnungseintrag',

@F4R0N F4R0N closed this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants