Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase github rate limit with multiple PATs #58

Merged
merged 2 commits into from Jul 15, 2020

Conversation

anuraghazra
Copy link
Owner

@anuraghazra anuraghazra commented Jul 15, 2020

Work in Progress, special thanks to @filiptronicek @ApurvShah007 @garvit-joshi

fixes #51

TODO:

  • write tests
  • refactor code
  • add retry logic in pin.js

src/fetchStats.js Outdated Show resolved Hide resolved
@anuraghazra
Copy link
Owner Author

anuraghazra commented Jul 15, 2020

preview to check if everything works nicely

@anuraghazra
Copy link
Owner Author

anuraghazra commented Jul 15, 2020

@ApurvShah007 what do you mean by not visible?

@ApurvShah007

This comment has been minimized.

@anuraghazra

This comment has been minimized.

api/pin.js Outdated Show resolved Hide resolved
@anuraghazra
Copy link
Owner Author

anuraghazra commented Jul 15, 2020

Okay i think it's ready to be merged @filiptronicek @nombrekeff 😄

@filiptronicek
Copy link
Contributor

filiptronicek commented Jul 15, 2020

I think too, :shipit:

@anuraghazra anuraghazra merged commit 9328a57 into master Jul 15, 2020
@anuraghazra
Copy link
Owner Author

anuraghazra commented Jul 15, 2020

Yey! and we also just hit 700 stars 🌟

@ApurvShah007
Copy link

ApurvShah007 commented Jul 15, 2020

Congrats on making such an amazing project.

@nombrekeff
Copy link
Contributor

nombrekeff commented Jul 15, 2020

Nice! Looking good, also congrats on 700

@ankurk91
Copy link

ankurk91 commented Jul 20, 2020

can you guys allows us to specify the max-age header through query parameter?

@nombrekeff
Copy link
Contributor

nombrekeff commented Jul 20, 2020

can you guys allows us to specify the max-age header through query parameter?

Hey, @ankurk91. This is being discussed in #82 if you want to add something.

@OctoberToEscape
Copy link

OctoberToEscape commented Aug 14, 2020

你们好

@anuraghazra anuraghazra deleted the fix-ratelimit branch Oct 31, 2020
@laureanray
Copy link

laureanray commented Nov 17, 2020

Hello guys, I know this isn't the best place to ask this but how did you get multiple PATs? Did you used multiple GitHub accounts? Because as far as I know the rate limit is shared within the account regardless of how many PATs you generate.

@anuraghazra
Copy link
Owner Author

anuraghazra commented Nov 17, 2020

@laureanray yeah we have multiple PATs from different github accounts. I think we currently have 7 of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants