Skip to content

Tony/630 try another webid#643

Merged
gjwgit merged 1 commit into
devfrom
tony/630_try_another_webid
May 20, 2026
Merged

Tony/630 try another webid#643
gjwgit merged 1 commit into
devfrom
tony/630_try_another_webid

Conversation

@tonypioneer
Copy link
Copy Markdown
Collaborator

@tonypioneer tonypioneer commented May 15, 2026

… when the user closes the browser window before completing login

Pull Request Details

Description

Added cancelSolidAuthenticate() so callers can abort a stuck OAuth flow when the user closes the browser window before completing login.

Related Issues

#630

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

Run RioPod using tony/630_try_another_webid branch to test, and follow the steps below.

  • Started RioPod and clicked on "Try another WebID"
  • Close the web browser. The app were still showing the loading animation.
  • Then clicked on the Cancel button, and clicked on "Try another WebID" again.
  • The web browser popped up again, and see messages in CLI.

Checklist

  • Screenshots included in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

… when the user closes the browser window before completing login
@gjwgit gjwgit requested review from anushkavidanage and removed request for gjwgit May 18, 2026 03:55
Copy link
Copy Markdown
Collaborator

@srodriguez142857 srodriguez142857 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All went smoothly in my tests; the functionality is working as expected.
Thanks @tonypioneer.

@gjwgit gjwgit merged commit fbe533b into dev May 20, 2026
31 of 40 checks passed
@gjwgit gjwgit deleted the tony/630_try_another_webid branch May 20, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SOLIPOD: Error after accidently closing the Web browser window during Login

3 participants