Amogh/Fix Security Key popup cancellation bug #281

[Amoghhosamane]

Pull Request Details

Description

Fixes the Security Key popup cancellation workflow for Issue #281.

Previously, cancelling the Security Key prompt could still allow navigation to continue into the application or continue file operations, even when the user intended to abort the process. The issue occurred because the fullscreen SecurityKeyUI used pushReplacement during cancellation and the calling flows did not properly await or validate cancellation results.

This PR updates the authentication and file operation flows to correctly stop execution when the Security Key popup is cancelled.

Key updates include:

• Updated SecurityKeyUI cancel behavior to use Navigator.pop(context, false)

• Modified getKeyFromUserIfRequired() to return Future<bool>

• Added cancellation handling in:

  • SolidLoginAuthHandler
  • SolidLoginActions
  • file upload/download/print operations

• Prevented continuation of workflows after user cancellation

• Fixed lint issues related to flow control braces

• Verified no unrelated formatting or feature changes are included

Modified files:

• lib/src/widgets/security_key_ui.dart
• lib/src/utils/solid_pod_helpers.dart
• lib/src/widgets/solid_login_auth_handler.dart
• lib/src/widgets/solid_login_actions.dart
• lib/src/utils/solid_file_operations_upload.dart
• lib/src/utils/solid_file_operations_download.dart
• lib/src/utils/solid_file_operations_print.dart

Related Issues

Fixes #281

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How To Test?

1. Run:

flutter pub get
flutter run

2. Trigger any workflow requiring the Security Key popup:

• Login flow
• Upload file
• Download file
• Print file

3. Click "Cancel" on the Security Key popup.

4. Verify:

• The popup closes correctly
• Navigation does not continue
• File operations are aborted cleanly
• No unintended transition to the main application occurs

5. Run validation:

flutter analyze
dart format .
make prep
make qtest

Checklist

• Screenshots included here/in linked issue #

• Changes adhere to the style and coding guidelines

• I have performed a self-review of my code

• I have commented my code, particularly in hard-to-understand areas

• I have made corresponding changes to the documentation

• Any dependent changes have been merged and published in downstream modules

• The update contains no confidential information

• The update has no duplicated content

• No lint check errors are related to these changes (make prep or flutter analyze lib)

• Integration test dart test output or screenshot included in issue #

• I tested the PR on these devices:

  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web

• I have identified reviewers

• The PR has been approved by reviewers

Finalising

• Merge dev into this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev