New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect-redis - ERR wrong number of arguments for 'set' command #298

Closed
ikb42 opened this Issue Nov 21, 2015 · 8 comments

Comments

Projects
None yet
4 participants
@ikb42

ikb42 commented Nov 21, 2015

connect-redis version 3.0.1 appears to break anvil-connect when moving from successful user signin to authorize

{ [ReplyError: ERR wrong number of arguments for 'set' command] name: 'ReplyError', message: 'ERR wrong number of arguments for \'set\' command', command: { name: 'set', args: [ 'sess:xxxxxxxxxxxxx', '{"cookie":{"originalMaxAge":null,"expires":null,"httpOnly":true,"path":"/"},"amr":["pwd"],"user":"yyyyyyyyyyyyy","opbs":"zzzzzzzzzzz"}', 'EX', '86400' ] } } 

'ReplyError: ERR wrong number of arguments for \'set\' command\n at ReplyParser._parseResult 

(\\connect\\node_modules\\anvil-connect\\node_modules\\ioredis\\lib\\parsers\\ja vascript.js:39:14)\n at ReplyParser.execute (\\connect\\node_modules\\anvil-connect\\node_modules\\ioredis\\lib\\parsers\\javascript.js:139:20)\n at Socket.<anonymous> (\\project\\connect\\node_modules\\anvil-connect\\node_modules\\ioredis\\lib\\redis\\event_handler.js:90:22)\n at emitOne (events.js:77:13)\n at Socket.emit (events.js:169:7)\n at readableAddChunk (_stream_readable.js:146: 16)\n at Socket.Readable.push (_stream_readable.js:110:10)\n at TCP.onread (net.js:523:20)'
@christiansmith

This comment has been minimized.

Member

christiansmith commented Nov 22, 2015

@ikb42 thanks so much for helping find the problem and filing the issue.

Unfortunately, this isn't the first time a dependency has disregarded semantic versioning rules and sent us off on a bug hunt. Perhaps we should consider shrinkwrapping releases from now on.

@luin

This comment has been minimized.

luin commented Nov 23, 2015

Is it related with tj/connect-redis#164?

@christiansmith

This comment has been minimized.

Member

christiansmith commented Nov 27, 2015

@ikb42 which version of Redis are you running this against?

@christiansmith christiansmith added the wtf label Nov 27, 2015

@christiansmith

This comment has been minimized.

Member

christiansmith commented Nov 27, 2015

@luin thanks for pointing out this possibility :)

@christiansmith christiansmith added the bug label Nov 27, 2015

@ikb42

This comment has been minimized.

ikb42 commented Nov 28, 2015

redis_version:2.4.6

@EternalDeiwos

This comment has been minimized.

Member

EternalDeiwos commented Nov 28, 2015

@ikb42 would you be able to upgrade your server and see if that fixes the problem? @luin mentioned that redis servers older than 2.6.12 don't allow certain options on the SET command which seems to be the problem.

@ikb42

This comment has been minimized.

ikb42 commented Nov 28, 2015

Yes, done and all ok on: redis_version:2.8.2104 and

  "name": "connect-redis",
  "description": "Redis session store for Connect",
  "version": "3.0.1",
@EternalDeiwos

This comment has been minimized.

Member

EternalDeiwos commented Nov 28, 2015

Fantastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment