Steam asking for password to update /usr/bin/steam #9

Closed
hnsr opened this Issue Nov 22, 2012 · 9 comments

Projects

None yet

3 participants

@hnsr
hnsr commented Nov 22, 2012

Currently when I launch steam, ~/Steam/steam.sh will give me a gksudo prompt so that it can update /usr/bin/steam, which I guess would undo the patch applied to it by the steam-installer ebuild. Fortunately I can just hit cancel and steam will happily start, but I thought I'd file an issue for it anyway since it does get a bit annoying having to cancel that every time (and things might break if a user does allow it to update /usr/bin/steam).

I found that if you export STEAMSCRIPT (in /usr/bin/steam) to some dummy path that doesn't exist, this update-check is bypassed (see line ~120-125 in ~/Steam/steam.sh), but I don't know if there are any other undesirable side effects to doing this

Owner
anyc commented Nov 24, 2012

Hm okay, I see. I agree that it is not good practice to allow that. Does it help if you reinstall or remove steam-installer?

hnsr commented Nov 25, 2012

Reinstalling didn't help, but removing and then launching Steam with ~/Steam/steam.sh does seem to work

Owner
anyc commented Nov 28, 2012

I'd say we recommend the users to remove the installer in this case. It isn't required anyway, from my point of view. Its only merit is that one can type "steam" instead of "~/Seam/steam.sh". Allowing a unpredictable user script under control of external persons full root access to the filesystem is not acceptable. What do you think?

hnsr commented Nov 28, 2012

Yeah, I should point out that the STEAMSCRIPT trick is still working well for me, but I guess that might randomly stop working whenever ~/Steam/steam.sh gets updated. Will it still be possible to install a .desktop launcher that will launch ~/Steam/steam.sh?

Have you looked at /usr/bin/steam?

Go ahead, look. It's a shell script, and there's some preliminary logic there for detecting what distribution it's using. Right now, it's only just returning a code for 32-bit Ubuntu 12.xx. However, Valve themselves have said that right now they are targeting Ubuntu 12.xx and future versions will expand out to other distributions such as RedHat/Fedora, OpenSUSE, Arch, Gentoo, etc. So this script will get updated -- it's happened once already.

That said, it's a good thing that Valve is using sudo, and prompting the user. It should refine the notice more, though.

So what I would do, given this is a beta release of Steam, is to first require sudo in the build, and then add ewarn lines to let the root-bearing user know that Steam itself is beta, and that it will prompt the user to update /usr/bin/steam.

hnsr commented Dec 3, 2012

I am indeed aware of /usr/bin/steam - see the preceeding discussion. The problem is that in it's current state, it is being patched by the steam-installer ebuild to remove some debian/ubuntu-specific things, and allowing Steam to update this will undo these changes. Note that new revisions of the steam-installer ebuild do ship an up-to-date version of /usr/bin/steam.

Owner
anyc commented Dec 4, 2012
hnsr commented Dec 4, 2012

Ah, great :)

Owner
anyc commented Dec 14, 2012

I close this issue for now as it should be resolved by Valve. Please reopen, if the issue reappears.

@anyc anyc closed this Dec 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment