Skip to content

Brevo Webhook Mapping Updates #385

@originell

Description

@originell

Dear Team, first of all: great package. Been using it forever without a fail. Forever grateful!

While debugging an issue with the Brevo (ex SendInBlue) Webhooks, I've discovered 2 slightly related things I'd like to get your opinions about.

A) New Events PR

I noticed that Brevo now has a couple of new events that are not yet mapped in the webhook.

From what I've seen their docs, the new ones are:

  • complaint
  • error
  • proxy_open

I would suggest the following mapping updates:

  • complaint: (EventType.COMPLAINED, RejectReason.SPAM)
  • error: (EventType.FAILED, None)
  • proxy_open: (EventType.OPENED, None)

If these seem OK to you as well, I'd be happy to supply a PR as well. Just wanted to get a quick OK before investing the time :)

B) The "request" Event Question

Looking at the webhook view's event type mapping, I see this mapping here:

    event_types = {
# ...
        "request": (EventType.QUEUED, None),
# ...
    }

I was wondering why this is mapped to QUEUED and not SENT? If you can still remember.

The current docs seem to suggest that the request payload is meant as sent.


Thank you for taking the time maintaining this great package and also keeping the code as neat as it is!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions