Skip to content

Conversation

@costela
Copy link
Contributor

@costela costela commented Oct 26, 2018

Also remap "generic" failure reason to RejectReason.OTHER, instead of
BOUNCE.

fixes #130

also remap "generic" failure reason to RejectReason.OTHER, instead  of
BOUNCE
@costela
Copy link
Contributor Author

costela commented Oct 26, 2018

Please note the minor style change when setting event_type for the first time. The .get() style (as opposed to try/except) was already being used for reject_reason and makes the code IMHO slightly more homogenous. Let me know if the try/except style is preferred.

@medmunds
Copy link
Contributor

medmunds commented Nov 1, 2018

Looks great. Thanks for this.

@medmunds medmunds merged commit bb25715 into anymail:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal][Mailgun][webhooks] change event_types and reject_reason mappings

2 participants