DROID-4175 Widgets | Participants names #2946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
konstantiniiv
December 1, 2025 12:59
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors participant name resolution in widgets to use a centralized ParticipantSubscriptionContainer instead of looking up creators from individual chat preview dependencies. The main changes include:
- Introduction of a new extension function
resolveParticipantNamefor consistent participant name resolution across the codebase - Integration of
ParticipantSubscriptionContainerinto widget containers - Removal of the old
extractCreatorNamemethod in favor of the centralized approach
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ParticipantExtensions.kt | New extension function for resolving participant names with fallback chain (name → globalName → fallback) |
| ChatListWidgetContainer.kt | Integrated participant subscription container, removed old extractCreatorName method, updated flow to combine participants data |
| VaultViewModel.kt | Refactored to use new resolveParticipantName extension function in two methods (createChatSpaceView and createDataSpaceWithChatView) |
| WidgetContainerDelegate.kt | Added participantContainer as a dependency and passed it to ChatListWidgetContainer instances |
| HomeScreenViewModel.kt | Added participantContainer to constructor and factory, passed to WidgetContainerDelegateImpl |
| HomescreenDI.kt | Added participantSubscriptionContainer() to dependency interface |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
...entation/src/main/java/com/anytypeio/anytype/presentation/extension/ParticipantExtensions.kt
Show resolved
Hide resolved
...entation/src/main/java/com/anytypeio/anytype/presentation/extension/ParticipantExtensions.kt
Outdated
Show resolved
Hide resolved
konstantiniiv
deleted the
droid-4175-chat-preview-shows-other-members-as-unknown-in-vault
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?