DROID-4057 Vault | Deleted message preview #2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements proper handling of deleted message previews in the Vault feature by ensuring that when a message is null (deleted), all associated preview fields (creator name, message text, message time, and attachments) are set to null.
Key Changes:
- Added null-safe message extraction logic in both chat space view creation functions
- Modified creator name resolution to only execute when message exists
- Updated attachment preview building to check for message existence
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
presentation/src/main/java/com/anytypeio/anytype/presentation/vault/VaultViewModel.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/anytypeio/anytype/presentation/vault/VaultViewModel.kt
Outdated
Show resolved
Hide resolved
konstantiniiv
deleted the
droid-4057-vault-preview-is-empty-after-deleting-last-message-and-space
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?