IOS-5365 implement the async membership handling #4111

requilence · 2025-10-17T14:01:32Z

Refactored membership data management to work with new middleware caching behavior for faster app startup.

Problem

Middleware now returns cached membership/tiers data immediately (with noCache: false) instead of blocking on network calls. App startup was slow because we were forcing network calls with noCache: true.

Changes

Single Source of Truth Architecture

MembershipStatusStorage now owns all membership data (status + tiers)
Added tiersPublisher and currentTiers to protocol
UI subscribes to storage publishers instead of calling service directly

Fast Startup

Changed startSubscription() to use noCache: false (uses middleware in-memory cache)
Added refreshMembership() with noCache: true for explicit refresh after IAP purchases

Event Handling

Added membershipTiersUpdate event handling
membershipUpdate: Updates status using event data + existing tiers
membershipTiersUpdate: Builds all tiers from event data
Simple guard skips status update if tiers not available yet (edge case)

Tier Filtering

Added isTest and iosProductID properties to MembershipTier model
Storage builds ALL tiers without filtering
UI filters tiers when rendering based on:
- Test tiers (via FeatureFlags.membershipTestTiers)
- iOS compatibility (has iosProductID OR is current user tier)

Files Modified

MembershipStatusStorage.swift - Core storage implementation
MembershipStatusStorageProtocol - Added tiers publishers
MembershipCoordinatorModel.swift - Subscribe to storage, filter tiers in UI
MembershipTier.swift - Added isTest, iosProductID properties
MembershipModelBuilder.swift - Pass new properties when building tiers
MembershipTier+Mocks.swift - Updated mocks
MembershipStatusStorageMock.swift - Added tiers support

refactor the membership storage and event handling

claude · 2025-10-17T14:03:58Z

Bugs/Issues

Race condition in event handling (MembershipStatusStorage.swift:73-91, 93-102)

Both membershipUpdate and membershipTiersUpdate event handlers create new Task blocks inside the for-loop
These tasks run concurrently without synchronization, creating potential race conditions when updating _status and _tiers
If multiple events arrive in quick succession, the order of updates to @published properties becomes non-deterministic
Fix: Remove the Task wrappers since handle(events:) is already called from a @mainactor task (line 64)

Missing tiers refresh (MembershipStatusStorage.swift:55-58)

refreshMembership() only refreshes status with noCache: true, but doesn't refresh tiers
If tiers data is stale after IAP purchase, UI won't show updated tier information
Fix: Add tiers refresh call with noCache: true

Silent error swallowing (MembershipCoordinatorModel.swift:65-68)

retryLoadTiers() calls refreshMembership() but doesn't check if it succeeds
If refresh fails, showTiersLoadingError remains false, leaving user with no feedback
Fix: Catch errors from refreshMembership() and set showTiersLoadingError = true on failure

Best Practices

Debug print statements in production (MembershipStatusStorage.swift:76, 87, 89)

Three print() statements will appear in production logs
Use proper logging framework or anytypeAssertionFailure() for errors per project conventions

Missing error handling (MembershipStatusStorage.swift:55-58)

refreshMembership() silently falls back to old _status on error using try? fallback pattern
No logging or analytics tracking when refresh fails after IAP purchase
Consider logging failures for debugging

Summary: 🚨 Major Issues - Race conditions in event handling, incomplete refresh logic, and silent error swallowing need fixing

ignatovv · 2025-10-17T15:10:49Z

Anytype/Sources/PresentationLayer/Flows/MembersipCoordinator/MembershipCoordinatorModel.swift

+    var tiers: [MembershipTier] {
+        let currentTierId = userMembership.tier?.type.id ?? 0
+        return allTiers
+            .filter { FeatureFlags.membershipTestTiers || !$0.isTest }
+            .filter { !$0.iosProductID.isEmpty || $0.type.id == currentTierId }
+    }


If we use this on the UI level, it will really affect performance. It's better to make this a published property and discard @Published private var allTiers: [MembershipTier] = []
because seems like it's not used anymore.

Also naming is really ambiguous. We have allTiers and tiers with no significant distinction and ability to understand what is what.

Agree. UX fields should not be computable.

ignatovv · 2025-10-17T15:16:30Z

Anytype/Sources/ServiceLayer/MembershipStatusStorage/MembershipStatusStorage.swift

                }
+
+            case .membershipTiersUpdate(let update):
+                Task {


Task created inside main actor will still be called on the main actor. If you want to do it in the backgroind you need to call Task.detached

Or remove main action from storage (legacy). Its better.

ignatovv · 2025-10-17T15:17:23Z

Modules/Services/Sources/Services/Membership/Model/MembershipTier.swift

+    public let isTest: Bool
+    public let iosProductID: String


We already have this properties available inside Anytype_Model_MembershipTierData I am not sure we need to introduce them here once again

ignatovv · 2025-10-17T15:19:24Z

Anytype/Sources/ServiceLayer/MembershipStatusStorage/MembershipStatusStorage.swift

+                        )
+                        _status.tier.flatMap { AnytypeAnalytics.instance().logChangePlan(tier: $0) }
+                        AnytypeAnalytics.instance().setMembershipTier(tier: _status.tier)
+                        print("[Membership] Updated membership status - tier: \(_status.tier?.name ?? "none")")


As claude mentioned - no prints in production code. It should be either assert or remove it

mgolovko · 2025-10-27T08:41:17Z

Anytype/Sources/ServiceLayer/MembershipStatusStorage/MembershipStatusStorage.swift

    @Published private var _status: MembershipStatus = .empty
-
+
+    var tiersPublisher: AnyPublisher<[MembershipTier], Never> { $_tiers.eraseToAnyPublisher() }


Legacy way. Try to use Async stream

reworked to use asynchronous streams

mgolovko · 2025-10-27T08:49:40Z

Anytype/Sources/ServiceLayer/MembershipStatusStorage/MembershipStatusStorage.swift

+
    private var subscription: AnyCancellable?
-    
+


Please disable "trim whitespace-only lines" in Xcode and rollback all this changes

…o ios-5365-membership-data-fetching-refactoring-integration-ios-refactor # Conflicts: # Libraryfile # Modules/ProtobufMessages/Sources/Protocol/Events/Anytype_Event.Membership.TiersUpdate.swift # Modules/ProtobufMessages/Sources/Protocol/Events/Anytype_Event.Message.swift

mgolovko · 2025-10-31T13:36:27Z

Anytype/Sources/PresentationLayer/Flows/MembersipCoordinator/MembershipCoordinatorModel.swift

-        membershipStatusStorage.statusPublisher.receiveOnMain().assign(to: &$userMembership)
+
+        statusTask = Task { [weak self] in
+            guard let self else { return }


Retain cycle

Use view.task.
Look example

mgolovko · 2025-10-31T13:39:24Z

Anytype/Sources/PresentationLayer/Flows/MembersipCoordinator/MembershipCoordinatorModel.swift

+        }
+
+        tiersTask = Task { [weak self] in
+            guard let self else { return }


the same https://github.com/anyproto/anytype-swift/pull/4111/files#r2481451021

mgolovko · 2025-10-31T13:40:17Z

Anytype/Sources/PresentationLayer/Flows/MembersipCoordinator/MembershipCoordinatorModel.swift

+    }
+
+    private func combinedStream() -> AsyncStream<(MembershipStatus, [MembershipTier])> {
+        let storage = membershipStatusStorage


use combineLastes in AsyncAlgoritms

mgolovko · 2025-10-31T13:42:19Z

Anytype/Sources/PresentationLayer/Flows/MembersipCoordinator/MembershipCoordinatorModel.swift

-            showTiersLoadingError = true
+
+    func retryLoadTiers() {
+        Task {


EmptyStateView support async throws methods ->retryLoadTiers() async throws

We try not to write Task { wherever possible.

mgolovko · 2025-10-31T13:44:27Z

Anytype/Sources/PresentationLayer/Membership/MembershipUpgradeViewModifier.swift

            }
            .onChange(of: reason) { _, reason in
-                model.updateState(reason: reason)
+                Task {


Make task(id: reason)

mgolovko · 2025-10-31T13:44:53Z

...Sources/PresentationLayer/Modules/Membership/InitialScreen/Views/MembershipPricingView.swift

                .foregroundColor(.Text.primary)
        case nil:
-            Rectangle().hidden().onAppear {
+            Rectangle().hidden().task {


Why task here?

mgolovko · 2025-10-31T13:45:24Z

...ayer/Modules/Membership/InitialScreen/Views/MembershipTierView/MembershipTierViewModel.swift

        let storage = Container.shared.membershipStatusStorage.resolve()
-        storage.statusPublisher.receiveOnMain().assign(to: &$userMembership)
+        statusTask = Task { [weak self] in
+            guard let self else { return }


the same https://github.com/anyproto/anytype-swift/pull/4111/files#r2481451021

mgolovko · 2025-10-31T13:45:39Z

...Layer/Modules/Membership/TierSelection/OwnershipView/MembershipOwnerInfoSheetViewModel.swift

        let storage = Container.shared.membershipStatusStorage.resolve()
-        storage.statusPublisher.receiveOnMain().assign(to: &$membership)
+        statusTask = Task { [weak self] in
+            guard let self else { return }


the same https://github.com/anyproto/anytype-swift/pull/4111/files#r2481451021

mgolovko · 2025-10-31T13:46:21Z

Anytype/Sources/ServiceLayer/MembershipStatusStorage/MembershipStatusStorage.swift

+    private var _status: MembershipStatus = .empty
+    private var _tiers: [MembershipTier] = []
+
+    private var statusContinuations: [UUID: AsyncStream<MembershipStatus>.Continuation] = [:]


Use AsyncToManyStream

mgolovko · 2025-10-31T13:46:48Z

Anytype/Sources/ServiceLayer/MembershipStatusStorage/MembershipStatusStorage.swift

+
    nonisolated init() { }
+
+    nonisolated func statusStream() -> AsyncStream<MembershipStatus> {


We are write var for publisher and stream without filters

mgolovko · 2025-10-31T13:47:04Z

Anytype/Sources/ServiceLayer/MembershipStatusStorage/MembershipStatusStorage.swift

+        _status
+    }
+
+    nonisolated func tiersStream() -> AsyncStream<[MembershipTier]> {


the same https://github.com/anyproto/anytype-swift/pull/4111/files#r2481486385

mgolovko · 2025-10-31T13:47:32Z

Anytype/Sources/ServiceLayer/MembershipStatusStorage/MembershipStatusStorage.swift

+        }
+    }
+
+    func currentTiers() async -> [MembershipTier] {


AsyncToManyStream allows you to read the last value in a nonisolated var. We try to read the var synchronously. This greatly simplifies the code.

mgolovko · 2025-10-31T13:48:35Z

Anytype/Sources/ServiceLayer/MembershipStatusStorage/MembershipStatusStorage.swift

-
-                    AnytypeAnalytics.instance().setMembershipTier(tier: _status.tier)
+                membershipUpdateTask?.cancel()
+                membershipUpdateTask = Task { [weak self, builder] in


Why task? You can mark handle as async and call any async methods inside

mgolovko

There are many tasks in an asynchronous context whose purpose is unclear. There’s code that could be simplified by using solutions from project.

requilence · 2025-11-03T10:33:53Z

decided to reimplement this by ios team, as original PR became bigger than I expected

IOS-5365 implement the async membership handling

142bf39

refactor the membership storage and event handling

requilence requested a review from a team as a code owner October 17, 2025 14:01

requilence mentioned this pull request Oct 17, 2025

IOS-5365 implement the async membership handling (simpler approach) #4112

Closed

ignatovv reviewed Oct 17, 2025

View reviewed changes

ignatovv requested changes Oct 17, 2025

View reviewed changes

ignatovv reviewed Oct 17, 2025

View reviewed changes

mgolovko reviewed Oct 27, 2025

View reviewed changes

requilence added 2 commits October 29, 2025 17:11

IOS-5365 address pr review comments

c74952e

mgolovko reviewed Oct 31, 2025

View reviewed changes

mgolovko requested changes Oct 31, 2025

View reviewed changes

requilence closed this Nov 3, 2025

github-actions bot locked and limited conversation to collaborators Nov 3, 2025

ignatovv deleted the ios-5365-membership-data-fetching-refactoring-integration-ios-refactor branch November 26, 2025 14:17

		@Published private var _status: MembershipStatus = .empty


		var tiersPublisher: AnyPublisher<[MembershipTier], Never> { $_tiers.eraseToAnyPublisher() }


		nonisolated init() { }

		nonisolated func statusStream() -> AsyncStream<MembershipStatus> {

IOS-5365 implement the async membership handling #4111

IOS-5365 implement the async membership handling #4111

Uh oh!

Conversation

requilence commented Oct 17, 2025

Problem

Changes

Single Source of Truth Architecture

Fast Startup

Event Handling

Tier Filtering

Files Modified

Uh oh!

claude bot commented Oct 17, 2025

Bugs/Issues

Best Practices

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgolovko Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

requilence Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgolovko Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgolovko left a comment

Choose a reason for hiding this comment

Uh oh!

requilence commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

mgolovko Oct 27, 2025 •

edited

Loading

requilence Oct 30, 2025 •

edited

Loading

mgolovko Oct 27, 2025 •

edited

Loading