From f9e495dda00a8a203f19da983fee52b9f3787d9a Mon Sep 17 00:00:00 2001
From: "AO Industries, Inc" <support@aoindustries.com>
Date: Mon, 23 Oct 2023 21:45:09 +0000
Subject: [PATCH] Allow null params on first build

---
 Jenkinsfile      | 8 ++++----
 book/Jenkinsfile | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Jenkinsfile b/Jenkinsfile
index 23f1c8f..6e0dc10 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -439,7 +439,7 @@ if (!binding.hasVariable('quietPeriod')) {
   binding.setVariable('quietPeriod', 10 + buildPriority * 2)
 }
 if (!binding.hasVariable('nice')) {
-  def nice = (params.BuildPriority as Integer) - 1;
+  def nice = (params.BuildPriority == null) ? 0 : ((params.BuildPriority as Integer) - 1);
   if (nice < 0) nice = 0;
   else if (nice > 19) nice = 19;
   binding.setVariable('nice', nice)
@@ -472,7 +472,7 @@ if (!binding.hasVariable('failureEmailTo')) {
 }
 
 // Common settings
-def mvnCommon   = "-Dstyle.color=always -Dmaven.gitcommitid.nativegit=true -DrequireLastBuild=${params.requireLastBuild} -Djenkins.buildNumber=${currentBuild.number} -N -U -Pjenkins,POST-SNAPSHOT${extraProfiles.isEmpty() ? '' : (',' + extraProfiles.join(','))}"
+def mvnCommon   = "-Dstyle.color=always -Dmaven.gitcommitid.nativegit=true -DrequireLastBuild=${params.requireLastBuild == null ? false : params.requireLastBuild} -Djenkins.buildNumber=${currentBuild.number} -N -U -Pjenkins,POST-SNAPSHOT${extraProfiles.isEmpty() ? '' : (',' + extraProfiles.join(','))}"
 def buildPhases = 'clean process-test-classes'
 
 // Determine nice command prefix or empty string for none
@@ -622,7 +622,7 @@ or any build that adds or removes build artifacts."""
     stage('Check Ready') {
       when {
         expression {
-          return params.abortOnUnreadyDependency
+          return (params.abortOnUnreadyDependency == null) ? true : params.abortOnUnreadyDependency
         }
       }
       steps {
@@ -959,7 +959,7 @@ void deploySteps(niceCmd, projectDir, deployJdk, maven, mavenOpts, mavenOptsJdk1
       filter: '**/*.pom, **/*.aar, **/*.jar, **/*.war, **/*.zip',
       target: 'target/last-successful-artifacts',
       flatten: true,
-      optional: !params.requireLastBuild
+      optional: (params.requireLastBuild == null) ? true : !params.requireLastBuild
     )
     // Temporarily move surefire-reports before withMaven to avoid duplicate logging of test results
     sh moveSurefireReportsScript()
diff --git a/book/Jenkinsfile b/book/Jenkinsfile
index 8cc8843..e2b713c 100644
--- a/book/Jenkinsfile
+++ b/book/Jenkinsfile
@@ -440,7 +440,7 @@ if (!binding.hasVariable('quietPeriod')) {
   binding.setVariable('quietPeriod', 10 + buildPriority * 2)
 }
 if (!binding.hasVariable('nice')) {
-  def nice = (params.BuildPriority as Integer) - 1;
+  def nice = (params.BuildPriority == null) ? 0 : ((params.BuildPriority as Integer) - 1);
   if (nice < 0) nice = 0;
   else if (nice > 19) nice = 19;
   binding.setVariable('nice', nice)
@@ -473,7 +473,7 @@ if (!binding.hasVariable('failureEmailTo')) {
 }
 
 // Common settings
-def mvnCommon   = "-Dstyle.color=always -Dmaven.gitcommitid.nativegit=true -DrequireLastBuild=${params.requireLastBuild} -Djenkins.buildNumber=${currentBuild.number} -N -U -Pjenkins,POST-SNAPSHOT${extraProfiles.isEmpty() ? '' : (',' + extraProfiles.join(','))}"
+def mvnCommon   = "-Dstyle.color=always -Dmaven.gitcommitid.nativegit=true -DrequireLastBuild=${params.requireLastBuild == null ? false : params.requireLastBuild} -Djenkins.buildNumber=${currentBuild.number} -N -U -Pjenkins,POST-SNAPSHOT${extraProfiles.isEmpty() ? '' : (',' + extraProfiles.join(','))}"
 def buildPhases = 'clean process-test-classes'
 
 // Determine nice command prefix or empty string for none
@@ -623,7 +623,7 @@ or any build that adds or removes build artifacts."""
     stage('Check Ready') {
       when {
         expression {
-          return params.abortOnUnreadyDependency
+          return (params.abortOnUnreadyDependency == null) ? true : params.abortOnUnreadyDependency
         }
       }
       steps {
@@ -960,7 +960,7 @@ void deploySteps(niceCmd, projectDir, deployJdk, maven, mavenOpts, mavenOptsJdk1
       filter: '**/*.pom, **/*.aar, **/*.jar, **/*.war, **/*.zip',
       target: 'target/last-successful-artifacts',
       flatten: true,
-      optional: !params.requireLastBuild
+      optional: (params.requireLastBuild == null) ? true : !params.requireLastBuild
     )
     // Temporarily move surefire-reports before withMaven to avoid duplicate logging of test results
     sh moveSurefireReportsScript()