Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] archive takes name from containing folder #188

Closed
gingerbeardman opened this issue May 13, 2018 · 16 comments
Closed

[REQ] archive takes name from containing folder #188

gingerbeardman opened this issue May 13, 2018 · 16 comments
Assignees
Milestone

Comments

@gingerbeardman
Copy link
Contributor

gingerbeardman commented May 13, 2018

Rather than "Compressed file.7z"

it would be nicer if the archive took the name of the containing folder.
7z on Windows does this. Very handy.

Keka already takes name of file if compressing a single file

@aonez aonez self-assigned this May 21, 2018
@aonez
Copy link
Owner

aonez commented May 21, 2018

I'm not sure about that one. For me it's confusing to compress a bunch of files in the Desktop and have a file named Desktop.7z...

@aonez
Copy link
Owner

aonez commented May 21, 2018

But adding a checkbox for that one shouldn't be a problem at all.

@sevdestruct
Copy link

sevdestruct commented Jul 8, 2018

Since my request got related to this. I thought I'd cast a comment into this for discussion, as I think I agree with @aonez on this one.

What is the use case of this? Seems to be an unnecessary optional setting with little to gain, but I mean no disrespect, just curious about the use case if you can explain why it's handy.

Wouldn't Desktop.7z, Desktop 2.7zDocuments.7z, Documents 2.7z basically the same as Compressed file 2.7z or Apple's Archive.zip and Archive 2.zip etc… as it gets created in that containing folder giving it context by position… Considering that folders dropped onto Keka already compress into this type of naming, what exactly is the benefit?

Would inference of the type of things archived or simply the leading file or folder give more context…

[item x] and 23 others.7z

…for instance, wouldn't this be more relevant than the containing directory they came from? I think that would be a more universal use case when archiving queued batches without losing context of what got batched after (especially when using 'Delete file(s) after compression'). Thoughts?

@gingerbeardman
Copy link
Contributor Author

gingerbeardman commented Jul 8, 2018

It's something I use frequently and miss in Keka, not something I've just thought up that might be nice 😉

The use case is when I want to archive some files (but not the whole folder) or if I do not want the folder name stored in the archive. Currently I have to do a manual rename afterwards.

At the very least "Desktop.zip" is descriptive of where the contents came from. "Compressed file.zip" or "Archive.zip" could come from anywhere, and if I have multiple of them then it's an inconvenience.

@sevdestruct
Copy link

sevdestruct commented Jul 9, 2018

Fair enough…I guess I can think of a couple more instances where that might be useful as an optional checkbox, after pondering about it a bit.

What are your thoughts on the other suggestion I made above, might be a better default than Compressed file #.7z in general, instead of as an alternate to the request here. Perhaps I should move that to it's own request ticket…

@gingerbeardman
Copy link
Contributor Author

gingerbeardman commented Jul 9, 2018

Your suggestion is interesting, I think it would be useful sometimes but how much would need me to try it out for a while.

Here's me using 7z on Windows just now... I created and named the folder to group those files, so why not use it to name the archive? That is very elegant to me.

screen shot 2018-07-09 at 01 09 39

@aonez
Copy link
Owner

aonez commented Jul 9, 2018

@gingerbeardman I also use 7-Zip in Windows environments and this is the default behaviour. Being so simple to implementation, and it benefiting some users, I don't see why not adding that one.

@aonez
Copy link
Owner

aonez commented Jul 9, 2018

A check will go below Same as original file, something like Name as containing folder if multiple files

screen shot 2018-07-09 at 14 08 13

@Askhento
Copy link

A check will go below Same as original file, something like Name as containing folder if multiple files

screen shot 2018-07-09 at 14 08 13

Hello, I've opened a duplicate. Sorry for that.
Where can I find this option you mentioned in a screenshot? Settings?

@aonez
Copy link
Owner

aonez commented Dec 18, 2019

Where can I find this option you mentioned in a screenshot? Settings?

Will be there, but it's not yet implemented.

@aonez aonez added the fixed label Dec 18, 2019
@aonez
Copy link
Owner

aonez commented Dec 18, 2019

Would inference of the type of things archived or simply the leading file or folder give more context…

@sevdestruct sorry for the late response. That has been asked again in #501. This is hard to accomplish in a way that everyone recognizes the file and is useful and depending on the complexity may also have a performance impact.

Right now I'm not considering that option since counting the files might be 👍🏼 for 10 but not for 10.000, imagine detecting a pattern or something else. The name selection should be very fast.

@aonez
Copy link
Owner

aonez commented Dec 20, 2019

@gingerbeardman & @Askhento take a look at the latest dev build:
https://github.com/aonez/Keka/releases/tag/v1.2.0-dev.3742

There you have this option (enabled by default in new installations).

Screen Shot 2019-12-20 at 13 42 54

@Askhento
Copy link

@gingerbeardman & @Askhento take a look at the latest dev build:
https://github.com/aonez/Keka/releases/tag/v1.2.0-dev.3742

There you have this option (enabled by default in new installations).

Screen Shot 2019-12-20 at 13 42 54

Wow you made it really fast!
I also made an automator with bash script :D

Ok have installed it by dragging into Applications and left both versions, but new one looks the same.

image

Where all the setting?

@aonez
Copy link
Owner

aonez commented Dec 20, 2019 via email

@Askhento
Copy link

Yes! Works as expected.
Is it okay to ask about implementation of this feature? Just to compare the solutions...

@sevdestruct
Copy link

Would inference of the type of things archived or simply the leading file or folder give more context…

@sevdestruct sorry for the late response. That has been asked again in #501. This is hard to accomplish in a way that everyone recognizes the file and is useful and depending on the complexity may also have a performance impact.

Right now I'm not considering that option since counting the files might be 👍🏼 for 10 but not for 10.000, imagine detecting a pattern or something else. The name selection should be very fast.

Hey @aonez It's quite alright. I've been so busy this past year - happy to see some movement on conversations here. I'm trying to catch up on side projects and contributions here on github for the new year.

@aonez aonez closed this as completed Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants