Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct French translations #302

Closed
ejb4u opened this issue Oct 8, 2018 · 5 comments
Closed

Correct French translations #302

ejb4u opened this issue Oct 8, 2018 · 5 comments

Comments

@ejb4u
Copy link

@ejb4u ejb4u commented Oct 8, 2018

There are some translations missing in French.
I've uploaded the latest files and added the missing translations. Some non consistencies were also corrected.
The translation files are attached.
KekaFrench.zip

@aonez aonez added enhancement and removed zip labels Oct 8, 2018
@aonez aonez self-assigned this Oct 8, 2018
@aonez aonez added this to the 1.1.6 milestone Oct 8, 2018
@aonez
Copy link
Owner

@aonez aonez commented Oct 8, 2018

Thanks a lot @ejb4u! You can check this build with your changes: Keka-r2952-fr.7z

How would you like to appear in the credits?

Loading

@aonez aonez added the gui label Oct 9, 2018
@ejb4u
Copy link
Author

@ejb4u ejb4u commented Oct 16, 2018

Localizable.strings.zip
There was a space missing in the Localizable.strings file. Here is the latest release.

You can add me as "Ejb4u", it's fine, it's my developer name ;-)
But the credit also goes to a friend who reviewed all the translations and who found some improvements. Could you please add him to the credits as "Jayflo276" ?

We tried your build with the translations, and except for the space missing, everything is fine.
By the way, when do you expect to release a new version of Keka with the updated French translations?

Thanks

Loading

@aonez
Copy link
Owner

@aonez aonez commented Oct 16, 2018

Thanks a lot @ejb4u! I'll add both of you :)

By the way, when do you expect to release a new version of Keka with the updated French translations?

Version 1.1.5 was blocked in the MAS review process, so I was forced to rework (again) some of the file access elements of Keka before a new release can be publicly available. Hopefully no more than two weeks...

Loading

@aonez aonez removed this from the 1.1.6 milestone Oct 19, 2018
@aonez aonez added this to the 1.1.5 milestone Oct 19, 2018
@aonez
Copy link
Owner

@aonez aonez commented Nov 1, 2018

@ejb4u 1.1.5 released with your updates! Thanks again 😁

Loading

@aonez
Copy link
Owner

@aonez aonez commented Nov 17, 2020

@ejb4u I'm so so sorry I've missed to add you both on the credits! I've added you right away, for the next v1.2.3 revision.

Thanks again for your collaboration!

Loading

aonez added a commit that referenced this issue Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants