Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression options for tarball are disabled #317

Closed
applebait opened this issue Nov 1, 2018 · 8 comments
Closed

Compression options for tarball are disabled #317

applebait opened this issue Nov 1, 2018 · 8 comments
Assignees
Milestone

Comments

@applebait
Copy link

applebait commented Nov 1, 2018

I can't remember the exact version but it isn't possible to change the tarball creation compression settings.
TIA

@aonez
Copy link
Owner

aonez commented Nov 2, 2018

@applebait I'm not sure what you mean.

Note that TAR does not compress data, so no method selection here:

screen shot 2018-11-02 at 08 47 22

For GZIP, BZIP, XZ and LZIP, you can choose the method. Those are the TARBALLs:

screen shot 2018-11-02 at 08 47 31

@aonez aonez self-assigned this Nov 2, 2018
@aonez aonez added this to the 1.1.6 milestone Nov 2, 2018
@applebait
Copy link
Author

screen shot 2018-11-02 at 17 35 20
If you go to the Preferences the Default method for TAR is greyed out. In the past we could set the level of compression for a tarball, not that it's what I want, I need it to compact a file always without compression, and if you say so, so in the past there was something wrong.

@aonez
Copy link
Owner

aonez commented Nov 7, 2018

@applebait just checked and even version 0.1.2.1 (from 2009) has this option disabled in the preferences. This was the behaviour since the first begging, since TAR has no compression and this combo is useless there. GZIP, BZIP, XZ or LZIP can create tarballs and since they provide compression the combo is activated.

It was funny to check out 2009 work anyway. Thanks for the feedback @applebait 😊

@applebait
Copy link
Author

Can I upload a video here? I swear it allowed us to choose a tarball with or without compression… :/

@aonez
Copy link
Owner

aonez commented Nov 8, 2018

You can upload it to YouTube/Dropbox or your preferred site and attach the link :)

@aonez aonez reopened this Nov 8, 2018
@applebait
Copy link
Author

Oh boy, you're right! :) I'm really sorry! I've checked and as soon as I choose the TAR method again the compression field gets greyed out. What was tricking me was this compression option that if we choose ZIP with some compression as soon as we choose TAR we can't switch it back to No Compression. This now makes sense if you say the TAR is a file with no compression.

@aonez
Copy link
Owner

aonez commented Nov 8, 2018

if we choose ZIP with some compression as soon as we choose TAR we can't switch it back to No Compression

You see, that is a point. Maybe the method combo should be set to "No compression" once TAR (DMG & ISO too) is selected there, but those are two different settings and the method setting affects to the rest of the formats from the Advanced Window.

Maybe this can be enhanced like:

  • Non compression format selected
    • Set the combo to "No compression"
    • Keep the default method (applied with compression formats) to "Normal"

Thanks @applebait!

@aonez aonez removed this from the Look at milestone Nov 8, 2018
@aonez aonez added this to the 1.2.0 milestone Nov 8, 2018
@aonez aonez added the fixed label May 7, 2020
@aonez
Copy link
Owner

aonez commented Jun 10, 2020

Released in the latest dev build: v1.2.0-dev.3901

@aonez aonez closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants