Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App quits after extraction whilst Sparkle update alert is on screen #408

Open
gingerbeardman opened this issue May 4, 2019 · 8 comments
Open
Assignees
Milestone

Comments

@gingerbeardman
Copy link
Contributor

@gingerbeardman gingerbeardman commented May 4, 2019

Screen shot 2019-05-04 at 21 33 20

Once the app is quit, the only way to get this auto update notice is to:

  1. manually refresh
  2. wait

both are less than ideal.

would it be preferable to wait if the Sparkle dialog is showing?

@aonez aonez self-assigned this May 4, 2019
@aonez aonez added this to the 1.1.16 milestone May 4, 2019
@aonez
Copy link
Owner

@aonez aonez commented May 4, 2019

I can't reproduce this one, if the update window is shown, Keka stays opened for me. Did the window appeared automagically for you while extracting? I'll do more tests.

@gingerbeardman
Copy link
Contributor Author

@gingerbeardman gingerbeardman commented May 4, 2019

Did the window appeared automagically for you while extracting?

Yes

@aonez aonez removed this from the 1.1.16 milestone May 6, 2019
@aonez aonez added this to the 1.2.0 milestone May 6, 2019
@aonez aonez closed this in c181c81 May 8, 2019
@aonez aonez added the fixed label Jun 12, 2019
@aonez
Copy link
Owner

@aonez aonez commented Jun 12, 2019

I'm reopening this one, should be already fixed in 1.2.0

@aonez aonez reopened this Jun 12, 2019
@aonez aonez closed this in d3cb8c7 Sep 24, 2019
@aonez
Copy link
Owner

@aonez aonez commented Oct 10, 2019

Was closed by mistake 😅

@aonez aonez reopened this Oct 10, 2019
@gingerbeardman
Copy link
Contributor Author

@gingerbeardman gingerbeardman commented Oct 18, 2020

I got this again yesterday, with prompt to install 1.2.0-rc.1

I click update but the app closed.

@aonez aonez removed this from the 1.2.0 milestone Nov 10, 2020
@aonez aonez added this to the 1.2.1 milestone Nov 10, 2020
@aonez aonez removed this from the 1.2.1 milestone Nov 10, 2020
@aonez aonez added this to the 1.2.2 milestone Nov 10, 2020
@aonez aonez removed this from the 1.2.2 milestone Dec 14, 2020
@aonez aonez added this to the Look at milestone Dec 14, 2020
@aonez
Copy link
Owner

@aonez aonez commented Jan 12, 2021

I'm investigating #709 and reproduced your issue @gingerbeardman. Hopefully I can fix both issues at one!

@aonez
Copy link
Owner

@aonez aonez commented Jan 25, 2021

@gingerbeardman this should be fixed in 1.2.8.

The problem was that when "Install Update" button is pressed that window closes. If there're no other Keka windows open and is set to "Close Keka when no windows are open" Keka quits before the update process window appears.

@gingerbeardman
Copy link
Contributor Author

@gingerbeardman gingerbeardman commented Jan 25, 2021

Hoorah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants