Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress button as first responder to enable keyboard #475

Closed
pSpitzner opened this issue Nov 1, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@pSpitzner
Copy link

@pSpitzner pSpitzner commented Nov 1, 2019

I am using keka frequently to compress folders - launched from alfred via open with... (or alternatively, via services compress with keka). This is a very keyboard-centric workflow.

As shown in the screenshot, per default, the path selection window of keka is not the first responder. Instead, the progress window is frontmost. Therefore, one cannot simply press enter to start the compression. A mouse click is required to actiate the window first.

It would be great if we could invert this.

I believe makeFirstResponder (see apple documentation) is what would enable the desired behaviour.

Thanks for looking into it!
Best,
Paul

PS: Would be glad to try myself if you are still willing to share code after the copy-cat issue.

Screenshot 2019-11-01 at 13-27-46

@aonez aonez self-assigned this Nov 2, 2019
@aonez aonez added bug gui labels Nov 2, 2019
@aonez aonez added this to the 1.1.22 milestone Nov 2, 2019
@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Nov 2, 2019

Thanks for the tip @pSpitzner!

I believe makeFirstResponder

In fact this one is creating the issue 😂 it's being called for the tasks window after the save dialog appears.

The fix for one task is very straightforward, coming in 1.1.22. A proper fix for multiple tasks will come in 1.2.0, since it involves more changes.

@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Nov 2, 2019

Sorry I meant makeKeyAndOrderFront is creating the issue.

@aonez aonez added the fixed label Nov 8, 2019
@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Nov 8, 2019

Fixed build here: Keka-1.1.22r3389.7z

@aonez aonez closed this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.