Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Extract encrypted zip with wrong password makes non-ascii filename broken #484
When s user tries wrong password then retry with valid password for encrypted zip file, generated filename will be broken. Its contents are decrypted properly, though.
To reproduce, please find attached zip file. It was encrypted with a passphrase "password" and contains 日本語.txt encoded with Japanese charset Shift_JIS.
If you type valid password in the first time (3), generated filename will be correct. So it seems the retrying password input (4) makes Keka to forget the selected charset in (2).
Thanks for the precise feedback and the test file, @ko-zu!
The password retry is the bug here. The first extraction is done using