Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract encrypted zip with wrong password makes non-ascii filename broken #484

Closed
ko-zu opened this issue Nov 19, 2019 · 1 comment
Closed

Extract encrypted zip with wrong password makes non-ascii filename broken #484

ko-zu opened this issue Nov 19, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@ko-zu
Copy link

@ko-zu ko-zu commented Nov 19, 2019

When s user tries wrong password then retry with valid password for encrypted zip file, generated filename will be broken. Its contents are decrypted properly, though.

To reproduce, please find attached zip file. It was encrypted with a passphrase "password" and contains 日本語.txt encoded with Japanese charset Shift_JIS.
日本語.zip

  1. Open attached zip file with Keka.
  2. Select Shift_JIS for filename charset.
  3. Type wrong password "something"
  4. Type valid password "password"
  5. Check generated filename.

If you type valid password in the first time (3), generated filename will be correct. So it seems the retrying password input (4) makes Keka to forget the selected charset in (2).

@aonez aonez self-assigned this Nov 19, 2019
@aonez aonez added bug core labels Nov 19, 2019
@aonez aonez modified the milestones: 1.2.0, 1.1.23 Nov 19, 2019
@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Nov 19, 2019

Thanks for the precise feedback and the test file, @ko-zu!

The password retry is the bug here. The first extraction is done using unar and since it fails almost immediately (bad password) p7zip is used then (no encoding options). So the fix will be using p7zip with the same password used before.

@aonez aonez added the fixed label Nov 19, 2019
@aonez aonez closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.