Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compressed file(s) to the Bin after extraction / Move original file(s) to the Bin after compression #493

Closed
nikzic opened this issue Dec 4, 2019 · 21 comments
Assignees
Milestone

Comments

@nikzic
Copy link

@nikzic nikzic commented Dec 4, 2019

Hi,

I just updated to Catalina and I noticed that these two options are not working any more. I tired unchecking and rechecking them but they still do not work. Can you look into this?

Thanks!

@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 4, 2019

Hi @nikzic! Just checked and it's working for me. Does it fail always for you? Can you try for example in the Desktop?

If it fails, can you take a look at the Console.app (filtered by Keka) to see if there's any log there?

@aonez aonez added this to the 1.1.23 milestone Dec 4, 2019
@nikzic

This comment has been minimized.

Copy link
Author

@nikzic nikzic commented Dec 4, 2019

Hi @aonez, thanks so much for the quick reply. I just played around with it a bit, and it seems this is happening only on iCloud folders. Since my Documents and Desktop are in iCloud, the issue is present. When I try to zip/unzip something in non-iCloud folders, everything works perfectly. Before Catalina, this issue was not present in iCloud folders. I tried disabling the option "Show warning before removing from iCloud drive" in Finder preferences, wishfully thinking that may help, but it didn't. The issue is present on both my macs. In the Console, I don't see anything related to Keka, i.e. there is no item that has "Keka" in the Process column. Any other tips? :) BTW, Keka has access to my whole disk. I also now granted it access to iCloud folders specifically, but it is still the same.

@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 4, 2019

Reproduced! Thanks @nikzic, I'll do more testing tomorrow.

@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 4, 2019

This is the error:

Error Domain=NSCocoaErrorDomain Code=3328 "“file” couldn’t be moved to the Bin because the volume “Macintosh HD” doesn’t have one." UserInfo={NSURL=file:///Users/user/Library/Mobile%20Documents/com~apple~CloudDocs/file, NSUserStringVariant=Trash}
@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 4, 2019

I've reported it to Apple via the Feedback Assistant, stating that:

Calling trashItemAtURL with a path from iCloud Drive results in an error.

To reproduce:

Call trashItemAtURL with an iCloud Drive path (/Users/user/Library/Mobile Documents/com~apple~CloudDocs/file)

Result:

The call fail to move and will return an error with a message stating that the file couldn’t be moved to the Trash because the volume doesn’t have one.

Expected:

The file will be moved to the iCloud Drive trash, located at /Users/user/Library/Mobile Documents/com~apple~CloudDocs/.Trash

Catalina is half backed.

Will do a workaround, but this should be fixed by Apple. @nikzic if you can report it too.

@aonez aonez added the Apple SDK label Dec 4, 2019
@nikzic

This comment has been minimized.

Copy link
Author

@nikzic nikzic commented Dec 5, 2019

Thanks a lot, @aonez. Just reported it too

@aonez aonez added the fixed label Dec 5, 2019
@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 5, 2019

Already made a workaround for this, coming in next release :)

@nikzic

This comment has been minimized.

Copy link
Author

@nikzic nikzic commented Dec 5, 2019

Awesome! Thank you very much @aonez for this superb support!

@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 9, 2019

@nikzic 1.1.23/24 has this fixed, could you double check it works for you?

@nikzic

This comment has been minimized.

Copy link
Author

@nikzic nikzic commented Dec 9, 2019

@aonez I have installed the latest version from the App Store - 1.1.24, and I still have the same issue

@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 9, 2019

@nikzic can you check if you have a .Trash folder in you iCloud Drive?

if [ -d ~/Library/Mobile\ Documents/com\~apple\~CloudDocs/.Trash ]; then echo Yes; fi

If you do, please:

  1. Enable DevLog:
defaults write com.aone.keka DevLog true
  1. Restart Keka
  2. Do some operation with the Move to Trash option enabled
  3. Check in the Console.app if there're some messages like the one in #493 (comment):
@Darklocq

This comment has been minimized.

Copy link

@Darklocq Darklocq commented Dec 12, 2019

On-topic: I suppose you will need to resolve issues with 10.14 and 10.15 in Keka, but I hope this does not come at the cost of the app working for everyone else. Given that the average lifespan of a high-end Mac is over a decade, lots of us will be using older versions for a long time.

An off-topic digression:

Yeah, macOS 10.14 and 10.15 really are pretty half-baked, as you say above. This "death to 32-bit!" obsession of Apple's is wreaking havoc, especially when it collides with their largely unrelated mania for radically changing how various things work, for no clear reason, with each major release. (It seems mostly to be a combination of trying to make desktop computers look and work like phones, which is just stupid, and a desire to treat users like morons and increasingly restrict what they can do without Apple's permission, which is even more stupid and verging on Android-style evil.)

Lots of us, with a whole lot of money invested in MacOS X 10.6 through macOS 10.13 applications, are not going to move to 10.14 (which only supports old apps to an extent) and 10.15 (which just breaks them all) for years. I have a 12-core Mac Pro tower which (with the amount of RAM I have in it) can comfortably run macOS 10.13, and two different Linux VMs, and Windows 7, and Windows 10 (with Skyrim!) all at the same time. So if Apple thinks I'm going to throw that machine out and buy some expensive new "black box" Mac with no internal slots or bays for my current and expensive hardware, just so I can only use apps they say I can use (and have to buy again for the most part), well, they're just smokin' crack. (I can even run modern Metal 2 games on my current box as soon as a I get a new video card for it, and even the CPUs can be upgraded a step or two. I've already got USB 3 in it and other upgrades. I'll be using the same machine for several more years.) What Apple is doing is basically Microsoft and their Windows 8 and Windows 10 all over again (around 50% of businesses still use Windows 7, because it gets the job done and the upgrade path is mega-expensive when you factor in all the licensing and IT and productivity costs).

It chaps my butt that BBEdit and various other apps are no longer supporting 10.13 and lower at all. They're just going to lose customers.

@gingerbeardman

This comment has been minimized.

Copy link
Contributor

@gingerbeardman gingerbeardman commented Dec 12, 2019

It chaps my butt that BBEdit and various other apps are no longer supporting 10.13 and lower at all. They're just going to lose customers.

I agree on this. I would hope that developers map support to analytics of their current users, but in the case of 1Blocker (10.15 only!) that is not the case at all which is kind of worrying.

@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 12, 2019

@nikzic any update on the issue? I can't replicate anymore with 1.1.24 version.

I hope this does not come at the cost of the app working for everyone else

@Darklocq The idea is keeping legacy OSs compatible as long as possible. It was very sad to cut 10.6.

developers map support to analytics of their current users

@gingerbeardman & @Darklocq I only have some analytics on the website:

Dark blue : 10.15 | Green: 10.14 | Red: 10.13 | Yellow: 10.12 | Light blue: 10.11

Screen Shot 2019-12-12 at 20 32 08

So 10.11 is still almost 4%. 10.13 still has a long way to go.

@nikzic

This comment has been minimized.

Copy link
Author

@nikzic nikzic commented Dec 12, 2019

Hey @aonez, just did what you asked and I see no similar error message in the Console app! I suppose I did everything right in the Terminal? See attached and let me know if you see any issues. I am not a coder, just so you know :)
Screenshot 2019-12-12 at 21 08 28

@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 12, 2019

Thanks for the follow-up @nikzic! So there you checked that there's in fact a Trash in your iCloud Drive and activated the log mode on Keka.

Now I've found that sometimes even the workaround fails with this error:

Error Domain=NSCocoaErrorDomain Code=513 "“test” couldn’t be moved because you don’t have permission to access “.Trash”." UserInfo={NSSourceFilePathErrorKey=/Users/aone/Library/Mobile Documents/com~apple~CloudDocs/test, NSUserStringVariant=(
    Move
), NSDestinationFilePath=/Users/aone/Library/Mobile Documents/com~apple~CloudDocs/.Trash/test, NSFilePath=/Users/aone/Library/Mobile Documents/com~apple~CloudDocs/test, NSUnderlyingError=0x6000001784b0 {Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"}}

Can you add the iCloud Drive folder to the File Access (in the Keka -> Preferences) list and see if that helps?

Screenshot 2019-12-12 at 21 26 37

@nikzic

This comment has been minimized.

Copy link
Author

@nikzic nikzic commented Dec 13, 2019

Hi @aonez, actually I already granted Keka access to iCloud when we first figured out the issue is with iCloud files. See attached.
Screenshot 2019-12-13 at 15 17 31
The result is the same

@aonez aonez modified the milestones: 1.1.23, 1.1.25 Dec 16, 2019
@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 17, 2019

@nikzic please try this build and follow these steps so I can get more information of the issue in your machine.

@nikzic

This comment has been minimized.

Copy link
Author

@nikzic nikzic commented Dec 18, 2019

Hi @aonez I just installed the latest macOS update (10.15.2) and this issue is no longer present for me in the latest version from the App Store. I guess Apple fixed the bug you found :)

@aonez

This comment has been minimized.

Copy link
Owner

@aonez aonez commented Dec 18, 2019

You're right! I'll remove the workaround since it's no more needed. Thanks for all the feedback @nikzic!

@nikzic

This comment has been minimized.

Copy link
Author

@nikzic nikzic commented Dec 18, 2019

Thanks for the software, @aonez! The amount of time it saves me just by deleting compressed files is amazing. :)

@aonez aonez closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.