Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle non-writeable directory by using a default fallback path #500

Closed
Darklocq opened this issue Dec 12, 2019 · 16 comments
Closed
Assignees
Milestone

Comments

@Darklocq
Copy link

@Darklocq Darklocq commented Dec 12, 2019

When extracting files or creating a new archive, Keka seems to just fail if the current directory is not writable by the user. Using a recent beta version (the one with ACE 2.x support), the app actually just crashed. (I included a crash log from that in the upload for the other ticket, about that beta).

I would suggest that what it should really do is save out to a pre-defined location, ~/Desktop/ by default, but configurable as a preferences option. Some apps that do this sort of fallback saving use ~/Downloads/, and others use ~/Documents/ or ~/Documents/App_name_here/ or whatever, and people may want to adjust Keka's fallback path to match whatever they're used to their other tools doing, and/or to mesh into some other workflow like a directory-watching app, or whatever. User choice is generally a good thing, while the user's desktop is a pretty typical default location for things, both in Mac and in Windows.

Ideally, Keka would report that it has done this and why, e.g. "Filename(s) saved to /The/Fallback/Path/ because /The/Original/Directory/ was not writable."

@aonez
Copy link
Owner

@aonez aonez commented Dec 12, 2019

Thanks again @Darklocq! This was already suggested here #183. I've added the notification idea and the customization of the path there.

The actual fallback was already implemented in the ACE beta, it uses the Desktop as a fallback. Is not working for you in that beta?

@aonez aonez self-assigned this Dec 12, 2019
@aonez aonez added this to the 1.2.0 milestone Dec 12, 2019
@Darklocq
Copy link
Author

@Darklocq Darklocq commented Dec 12, 2019

As I noted in the other ticket about the beta with the ACE 2.x stuff in it: when I try to create an archive in a dir without write access, the app just crashes. So, I would not have seen that behavior being added. :-) The logs I linked to include that crash. That archive of logs is toward the (present) end of #402.

@aonez
Copy link
Owner

@aonez aonez commented Dec 12, 2019

I will double check then with the logs. This feature was developed just a two weeks ago so you're in fact one of the first to try it.

@stale
Copy link

@stale stale bot commented Jan 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 4, 2020
@Darklocq
Copy link
Author

@Darklocq Darklocq commented Jan 6, 2020

Did anything come up in the logs? I did try the dev version you pointed me to a couple of weeks ago, but it still hung when switching out of the application (in macOS 10.13.6), so I wasn't able to test much with it.

@stale stale bot removed the stale label Jan 6, 2020
@stale
Copy link

@stale stale bot commented Jan 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 29, 2020
@aonez aonez removed the stale label Jan 29, 2020
@stale
Copy link

@stale stale bot commented Feb 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 21, 2020
@aonez
Copy link
Owner

@aonez aonez commented Feb 23, 2020

@Darklocq did you had the chance to try the betas in another machine with 10.14?

@stale stale bot removed the stale label Feb 23, 2020
@aonez aonez added the blessed label Feb 23, 2020
@aonez
Copy link
Owner

@aonez aonez commented Feb 26, 2020

@Darklocq finally reproduced the hang. I'm looking for a fix now.

@aonez
Copy link
Owner

@aonez aonez commented Feb 27, 2020

@Darklocq it should be fixed in this build: Keka-1013

Please let me know if it works for you and also if the fallback works as expected.

@Darklocq
Copy link
Author

@Darklocq Darklocq commented Feb 29, 2020

As noted in other thread: I don't have another machine on which to run 10.13, nor any machine on which to run 10.14+ (my Mac will not do 10.14 without a hardware upgrade).

I've downloaded 1013, and will give it a shot. Curious what you did to reproduce the issue (which for me is 100% - there must be some major difference between my setup and your usual one!)

@aonez
Copy link
Owner

@aonez aonez commented Feb 29, 2020

Curious what you did to reproduce the issue (which for me is 100% - there must be some major difference between my setup and your usual one!

Really did nothing different... Not sure why was unable before, now its 100%. I'm using a Parallels VM.

I've downloaded 1013, and will give it a shot

Let me know when you have the chance :)

@Darklocq
Copy link
Author

@Darklocq Darklocq commented Feb 29, 2020

https://www.youtube.com/watch?v=AXwGVXD7qEQ

I've got it doing three compressions at once, and am able to leave and re-enter the app, add other jobs, change the preferences, etc., and it's all keeping to a reasonable CPU and RAM usage level.

https://www.youtube.com/watch?v=UArbzOExaBg

@Darklocq
Copy link
Author

@Darklocq Darklocq commented Feb 29, 2020

I would close this, but this was originally opened about fallback paths and handling of non-writeable directories; I'm not sure what the disposition of that matter was.

@aonez
Copy link
Owner

@aonez aonez commented Mar 17, 2020

@Darklocq the fallback system was already implemented, just now added the GUI (in Preferences - File Access) to customize the path. You can check it in this build:

https://github.com/aonez/Keka/releases/download/dev-test-builds/Keka-fallback.7z

@aonez aonez added the fixed label May 7, 2020
@aonez
Copy link
Owner

@aonez aonez commented Jun 10, 2020

Released in the latest dev build: v1.2.0-dev.3901

@aonez aonez closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants