Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI - Small design flaws. #536

Closed
Oleg-Chashko opened this issue Apr 6, 2020 · 15 comments
Closed

GUI - Small design flaws. #536

Oleg-Chashko opened this issue Apr 6, 2020 · 15 comments
Assignees
Milestone

Comments

@Oleg-Chashko
Copy link
Contributor

Oleg-Chashko commented Apr 6, 2020

Configuration
Keka version: [Keka v1.2.0-dev.3742]
macOS version: [10.15.4 (19E266)]

Describe the bug
1. Problems with the letters "W, V", possibly with some others.
2. The problem with centering vertically in the input windows.
I have attached examples, but that’s not all. Other windows have problems.

Screenshots
Bildschirmfoto 2020-04-06 um 09 48 52
Bildschirmfoto 2020-04-06 um 09 53 32
Bildschirmfoto 2020-04-06 um 09 26 52

@aonez
Copy link
Owner

aonez commented Apr 6, 2020

Not sure what is your point here...

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Apr 6, 2020

Not sure what is your point here...

No, I do not insist that I am right. Each artist sees this world in his own way. As a basis, I took "Apple-Mail".
Bildschirmfoto 2020-04-06 um 12 50 52
Bildschirmfoto 2020-04-06 um 13 11 37
Bildschirmfoto 2020-04-06 um 13 05 11
Bildschirmfoto 2020-04-06 um 13 06 40

@gingerbeardman
Copy link
Contributor

I love your attention to detail @Oleg-Chashko

@aonez I believe Oleg's point was that the IB layout would benefit from some tightening-up to remove the alignment/cropping issues he has listed.

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Apr 6, 2020

For me, "Keka" is the best archiver on MacOS. But the slightest geometric curvature for me is the "Perfectionist hell".
P.S.
Perfectionist Hell
There's no sulfur in perfectionist hell
no fire, and only slightly asymmetrically stand
chipped boilers.

@Oleg-Chashko Oleg-Chashko changed the title UI - Small design flaws. GUI - Small design flaws. Apr 6, 2020
@aonez aonez added this to the 1.2.0 milestone Apr 27, 2020
@aonez
Copy link
Owner

aonez commented Jun 10, 2020

@Oleg-Chashko just released the latest dev build: v1.2.0-dev.3901

All those issues should be fixed now!

@aonez aonez added the fixed label Jun 10, 2020
@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Jun 10, 2020

Latest dev build: v1.2.0-dev.3901
The input field, I would like to be centered in a vertical plane.
Screenshot 2020-06-10 at 21 49 08
Screenshot 2020-06-10 at 21 49 59
Screenshot 2020-06-10 at 21 51 03

@aonez
Copy link
Owner

aonez commented Jun 11, 2020

I wanted to ask you why here "Kekas icon"?

This is there since 1.1.0 early versions while playing around developing the format selector. Leaved it there for fun since it's only a line of code.

Screenshot 2020-06-11 at 08 59 52

@aonez
Copy link
Owner

aonez commented Jun 12, 2020

Will the opportunity, be returned to make, large icons of compression modes?

You can still use those icons if you disable the "Unified toolbar" in the preferences. You meant that?

@aonez
Copy link
Owner

aonez commented Jun 12, 2020

I'm not very good at Russian 😅 What are the grammatical errors in operations and queuing?

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Jun 13, 2020

@aonez

  1. Translated everything in the file (ru.lproj) into Russian, fixed errors with a space and grammar errors of the English language. The Russian language was written without errors, just not enough commas.
  2. In other language files (bg.lproj, de.lproj, en-GB.lproj & etc.), white space errors and English grammar errors. Will have to correct you!
  3. There is a problem! There is no line with the text in the language files:

Screenshot 2020-06-13 at 13 39 06

**This problem exists in all language files. Please enter this line in the language files, and it will be possible to change it into different languages. And I will translate into Russian in the file.**
  1. ru.lproj.zip

@Oleg-Chashko
Copy link
Contributor Author

This I showed which letters were spelled incorrectly. Errors with English and Russian words. This is already corrected text!
84504655-99a86300-acbc-11ea-9bcd-9909dcbdc092

@aonez
Copy link
Owner

aonez commented Jun 13, 2020

@Oleg-Chashko thanks a lot! Maybe you can try to clone the repository and create a pull request with your changes. Anyway I'll take a look at your attached file :)

If you find some more issues not related with the main topic "Small design flaws" better create a new issue, since this one is becoming hard to track...

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Jun 13, 2020

@Oleg-Chashko thanks a lot! Maybe you can try to clone the repository and create a pull request with your changes. Anyway I'll take a look at your attached file :)

If you find some more issues not related with the main topic "Small design flaws" better create a new issue, since this one is becoming hard to track...

@aonez
I just added translation and fixed the language pack. If you want to create a topic, transfer what you need there. And I, with pleasure, will join if you want.

aonez added a commit that referenced this issue Jul 14, 2020
aonez added a commit that referenced this issue Jul 15, 2020
@aonez
Copy link
Owner

aonez commented Jul 15, 2020

Finally found the time to merge your translation update and typo fixes 😅

@aonez
Copy link
Owner

aonez commented Jul 16, 2020

I'm closing this one, reopen if I've missed something. Thanks again @Oleg-Chashko!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants