-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQ] Add support for lrz / lrztar #549
Comments
Thanks @zenspider! It's already in the list #84. Did some tests yesterday with the stable version 0.631 and found no improvements over 7Z, that also uses LZMA. Only using zpaq If I see fit for it would be easy to support it in Keka :) |
Had some time and went ahead with this one. The progress bar is a little useless sometimes due to the steps used in LRZIP. I'm using LZMA compression but ZPAQ on the slowest setting. https://github.com/aonez/Keka/releases/download/dev-test-builds/Keka-LRZIP.7z |
Awesome. Thank you... If it's the same algs as 7Z then maybe I should just switch over to that. I'm good either way as long as I get those compression ratios. |
I'm adding it because ZPAQ, that sometimes has better ratio than LZMA! It is very, very slow but might be worth in some cases. |
So I tried using this version to extract an XZ archive containing an IMG file to test compression with, but after extraction the file just disappears haha. I tested it twice. It puts original in the trash, and the extracted file disappears. Just a heads up! |
@akrabu can you reproduce this while in a Keka debug session? Late 1.2.0 builds use a new extraction step, maybe it's failing for you. Also use a fallback folder (Desktop by default), check it's not going there the extraction. |
Thanks for the time @akrabu! So seems to be the new extraction step: 2020-05-07 09:42:00.154 The extraction at /Users/akrabu/Desktop/Keka-LRZIP.kextraction/Operation is empty Is ok to you if I send you a build with more logging for this issue? May I ask what macOS version are you using? |
@aonez Absolutely! I'm on 10.15.4 (Catalina)
|
Released in the latest dev build: v1.2.0-dev.3901 |
Sorry @akrabu forgot about the build! Can you test the last dev build? |
@aonez Everything seems to get stuck after 5 seconds of extraction... |
@akrabu can you check on the Console.app (filtered by Keka) if there are any more logs while you do an operation? |
@aonez Hey, sorry, I missed this message! But, v1.2.0-beta.1 appears to have fixed the problem. The latest betas weren't working for me at all and I started to use the main version. This one finally extracts though! Though it doesn't always show progress (like no window at all)? But at least it works haha |
Glad to hear that @akrabu! 👏🏼
By design in 1.2.0 Keka waits 0.5 seconds to show the tasks window. If the operation lasts less than that, you won't see the task window. Is that the case? Or is this happening with longer tasks? |
Ahhh, I believe that's the case. Thanks!
… On Jul 21, 2020, at 1:23 PM, aONe ***@***.***> wrote:
Glad to hear that @akrabu <https://github.com/akrabu>! 👏🏼
Though it doesn't always show progress (like no window at all)?
By design in 1.2.0 Keka waits 0.5 seconds to show the tasks window. If the operation lasts less than that, you won't see the task window. Is that the case? Or is this happening with longer tasks?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#549 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUM57FN4JCA7K47QINMMJTR4X2K7ANCNFSM4MPMBIIA>.
|
@aonez Spoke too soon - I'm extracting a 16GB multi-part RAR file and it's definitely working, and I see the pie-chart progress in the Finder, but there's no progress window anywhere. Just a heads up! In addition it stalled in the end again, and just sat there. I was able to "show contents" and copy the files out, plus verify integrity using the included MD5 sums, but Keka beta is apparently still not always extracting properly on my machine. :( |
@akrabu what machine are you using? Any special configuration that I can try to reproduce? Working on an external disk/format? Maybe you can take a look at the |
@akrabu reproduced the no show tasks window. Going to fix that! |
@aonez Looks like the extraction bug has popped back up.
Is there any way to toggle showing the extraction window? I have to queue up a second task to be able to cancel the first, and it makes the log messy haha. But basically it just sits there at this point. No errors or anything. So then I queue up a second extraction, cancel it, plus the first, in order to make it stop. |
I'll push the task window fix in a few |
@akrabu the task window bug is fixed https://github.com/aonez/Keka/releases/tag/v1.2.0-beta.2, can you check there the logs? |
@aonez I'm testing with an 834MB zip file, and I do get the window now! I like the orange color instead of blue, too haha. However, it still stops at the very end. It isn't frozen, it just doesn't finish. I still have full-disk access enabled. I can actually show the contents of the .kextraction folder and check the hashes and everything is intact. If I cancel, it deletes everything though. So currently I have to copy it out of the folder then cancel as a workaround.
|
Finally reproduced the issue! There's a bug that if you have "Inherit quarantine from downloaded files" disabled, the task does never finish (but the extraction does). Fixing it right away! Thanks a lot @akrabu!
Fixed in this build: https://github.com/aonez/Keka/releases/download/dev-test-builds/Keka-v1.2.0-dev.r4019.7z You can simply replace your current beta with this one :) |
@aonez Yay that fixed it! Never would have thought of that option as being the culprit haha. Thanks! |
Nice @akrabu! 😁 |
I've been testing lrz against some of my larger archives and even with default settings (eg not
-9
etc) it's beating them out. Also it uses ALL the available CPU so it seems to do it at a very nice clip as well. Would you be open to adding this compression format?The text was updated successfully, but these errors were encountered: