Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Microsoft OneDrive #608

Closed
Oleg-Chashko opened this issue Aug 11, 2020 · 10 comments
Closed

Conflict with Microsoft OneDrive #608

Oleg-Chashko opened this issue Aug 11, 2020 · 10 comments

Comments

@Oleg-Chashko
Copy link
Contributor

Oleg-Chashko commented Aug 11, 2020

Configuration
Keka version: 1.2.0
macOS version: 11.0.1 Beta (20B5022a)

"Keka Finder Integration" partially breaks, "OneDrive.app" its integration with Finder

Keka Finder Integration

Screenshot 2020-08-11 at 17 02 20

Screen Recording:
Screen Recording 2020-08-11 at 16.37.28.zip

@aonez
Copy link
Owner

aonez commented Aug 11, 2020

That’s odd... I don’t use OneDrive but will try to replicate this tomorrow. Thanks for the feedback @Oleg-Chashko!

@aonez aonez added the appex label Aug 11, 2020
@aonez aonez added this to the Look at milestone Aug 11, 2020
@Oleg-Chashko Oleg-Chashko changed the title "Keka Finder Integration" partially breaks, "OneDrive.app" its integration with Finder Conflict with Microsoft OneDrive Nov 10, 2020
@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Nov 23, 2020

Will this bug be fixed?

@aonez
Copy link
Owner

aonez commented Nov 23, 2020

Sorry @Oleg-Chashko will be checking that one today 😅

@aonez aonez modified the milestones: Look at, 1.2.4 Nov 23, 2020
@aonez
Copy link
Owner

aonez commented Nov 23, 2020

So it seems the first extension that registers for a directory has priority for those flags. I'll investigate if there's any way to change this behaviour.

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Nov 23, 2020

So it seems the first extension that registers for a directory has priority for those flags. I'll investigate if there's any way to change this behaviour.

I have a conflict when activating the item: Show Keka actions in Finder`s contextual menu.

Bildschirmfoto 2020-11-23 um 13 33 51

Good luck with solving the problem.

@aonez
Copy link
Owner

aonez commented Nov 23, 2020

So far:

  • The first extension that registers a directory owns gets requestBadgeIdentifierForURL, even if that extension does not implement that method. Subsequent extensions that register for that directory do not get that call.
  • All extensions monitoring a directory receive notifications for beginObservingDirectoryAtURL and endObservingDirectoryAtURL so the sync actually works on all extensions.

I might be missing something but right now I think coexistence of multiple Finder extensions for the same directories is partially implemented. Would be good if I can simply tell FIFinderSync I only want to use menuForMenuKind (the contextual menu) and not the other methods so other Finder extensions can use them.

At this point I can only think of a selective sync for the Keka Finder Extension so you use the extension in the directories manually selected. Similar to the File Access list.

In fact it's already partially developed (but not activated) to register the extension only in the File Access items, so I might end this development and enable the option:

Screenshot 2020-11-23 at 17 00 09

@aonez aonez modified the milestones: 1.2.4, Future Nov 23, 2020
@aonez
Copy link
Owner

aonez commented Nov 23, 2020

I'm gonna ask Apple if I'm missing something, if not I will create a feedback report so they know this coexistence of multiple extensions on the same directory is not properly implemented.

@aonez aonez modified the milestones: Future, 1.2.5 Nov 23, 2020
@aonez
Copy link
Owner

aonez commented Nov 25, 2020

I will not use the File Access list because as soon as you extract something in the OneDrive folder it will be added to that list and the bug will appear. I'll need to add a new list for the context menu.

@aonez
Copy link
Owner

aonez commented Dec 8, 2020

Should be fixed with the customizable list: Keka-v1.2.5-r4326.7z

@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Dec 8, 2020

Should be fixed with the customizable list: Keka-v1.2.5-r4326.7z

@aonez
Checked there is no more conflict. I like it, Thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants