Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finder Extension shows incorrect external volume sidebar icons #667

Open
shuuiran opened this issue Nov 17, 2020 · 20 comments
Open

Finder Extension shows incorrect external volume sidebar icons #667

shuuiran opened this issue Nov 17, 2020 · 20 comments

Comments

@shuuiran
Copy link

shuuiran commented Nov 17, 2020

Workaround

This seems to be a bug in macOS. As a workaround you can disable the external volume integration of Keka's context menu in the Preferences. Available in Keka v1.2.3 and later. Still not fixed in macOS 12 Monterey, as reported by @kapitainsky in #938.

Possible extra information about this issue 👉 knurling/ServiceStation#51

Screen Shot 2021-11-01 at 12 51 34

Workaround for folders (not external volumes)

👉 Take a look at this comment: #667 (comment)


Original issue

Configuration

  • Keka version: 1.2.2 (4199)
  • macOS version: 11.0.1 (20B29)

Describe the bug

在macOS Big Sur 11.0.1 (20B29), 在打开了Keka的Finder扩展的情况下,Finder里外接磁盘的图标显示会不正确。
in macOS Big Sur 11.0.1 (20B29), If the Keka extension is enabled, the external hard drives icon is incorrect in Finder

Screenshots

截屏2020-11-17 下午3 05 12

@shuuiran shuuiran added the bug label Nov 17, 2020
@aonez aonez added this to the Look at milestone Nov 17, 2020
@shuuiran
Copy link
Author

append video
屏幕录制2020-11-17 下午5.18.42.zip

@aonez
Copy link
Owner

aonez commented Nov 17, 2020

Thanks @zhouweiluan!

@gingerbeardman
Copy link
Contributor

This is an Apple bug. Workaround is here: knurling/ServiceStation#40 (comment)

@aonez
Copy link
Owner

aonez commented Nov 17, 2020

So seems that this should be fixed by Apple then... I can meanwhile add an option to disable external disk monitoring, so the Finder Extension will only be present at external disks that where mounted when the extension started.

The problem appears when the external volume is assigned in the Finder Extension directoryURLs, I thought it was about NSWorkspaceDidMountNotification and such.

@aonez
Copy link
Owner

aonez commented Nov 17, 2020

This build has the option to disable the external volumes integration: Keka-appx-volumes.7z

I've tested and this fixes the issue although renders the context menu useless outside the OS drive 😞

Hopefully Apple can fix this soon.

@aonez aonez modified the milestones: 1.2.3, How-to Nov 20, 2020
@aonez
Copy link
Owner

aonez commented Nov 20, 2020

Version 1.2.3 is released now with the option to workaround this issue.

@pkamb
Copy link

pkamb commented Nov 21, 2020

Where did you get the information about "Big Sur 11.0.1 and earlier"?

I am reproducing this issue on Big Sur 11.1 Beta (20C5048l) on a DTK. I don't yet have access to a non-beta install.

I opened a ticket for it in my Finder Sync Extension here: knurling/ServiceStation#51

@aonez
Copy link
Owner

aonez commented Nov 22, 2020

I meant 11.0 and 11.0.1... Haven't had the change to try 11.1 beta yet. Just changed the descriptions there's no confusion. I've already posted in your previous issue knurling/ServiceStation#40 (comment). Will be creating a feedback ticket for  pointing this issue and yours.

Sadly this error reminds me of #453, an error introduced in Catalina that was fixed in Big Sur... Hopefully they fix this one in Big Sur and not in macOS 12.0 or whatever they call the new one.

@lfom
Copy link

lfom commented Feb 3, 2021

@aonez I also see the same problem with Keka v1.2.9 (4434) on Catalina 10.15.7: when "Show in external volumes" or the Finder extension is enabled, disks other than the boot one are shown as a generic folder icon.

Screen Shot 2021-02-03 at 07 44 15

@gingerbeardman
Copy link
Contributor

@lfom please read earlier comments

@aonez
Copy link
Owner

aonez commented Feb 3, 2021

@lfom just disable external volumes in Keka - Preferences - Finder extension as stated in the main topic of this issue. Thanks!

@lfom
Copy link

lfom commented Feb 3, 2021

Yeah, I know the workaround (as I wrote in my previous comment). I just wanted to report that it also happens in Catalina, and also in Mojave by the way, so it is not specific to BS.

@aonez
Copy link
Owner

aonez commented Feb 3, 2021

Ah thanks @lfom! I did found this in Catalina but did not tested Mojave.

@aonez aonez added the Catalina label Feb 3, 2021
@aonez aonez changed the title [BUG]Keka Extension in Big Sur(20B29), external hard drives icon is incorrect in Finder [BUG] Keka Extension in Big Sur and earlier -> external hard drives icon is incorrect in Finder Feb 3, 2021
@gingerbeardman
Copy link
Contributor

I can confirm it happens in Mojave.

@aonez aonez changed the title [BUG] Keka Extension in Big Sur and earlier -> external hard drives icon is incorrect in Finder [BUG] Finder Extension shows incorrect external volume sidebar icons Feb 25, 2021
@aonez aonez pinned this issue Feb 25, 2021
@l782993610
Copy link

Still happen on Big Sur 11.4 (Mac pro 2020 M1)

@J-Wick4
Copy link

J-Wick4 commented Nov 7, 2021

Confirmed this happens on Big Sur and corrected it by turning off external volumes in settings.

@lexrus
Copy link

lexrus commented Nov 12, 2021

1adf06a6-e79e-4ae5-9f64-0da6a05e6cd0-1

I wonder how does Dropbox workaround this issue...

@aonez
Copy link
Owner

aonez commented Nov 12, 2021

@lexrus Dropbox add an icon to its folder, as I remember. Keka does not add any icon to any folder but macOS renders bad icons to external drives.

@aonez aonez changed the title [BUG] Finder Extension shows incorrect external volume sidebar icons Finder Extension shows incorrect external volume sidebar icons Nov 12, 2021
@sbarex
Copy link

sbarex commented Nov 29, 2021

On my system the bug also occurs for the normal monitored folder visible in the sidebar.

@aonez
Copy link
Owner

aonez commented Dec 1, 2021

@sbarex this will affect all directories (folders or volumes), other than this ones (from Apple's doc):

NOTE
The sidebar icons you provide will replace the default folder icons in the Finder’s sidebar for any of the root folders that your extension is monitoring. This icon does not replace the icon for any folders contained by your monitored folder. It also does not replace the icon for any system folders that you may be monitoring (for example, Documents, Desktop, Applications, and Downloads).

So you can simply add parent folder to the Finder Extension list instead of the folder you're adding to the sidebar.

An example:

  • Adding /Users/sbarex/Documents/MySidebarFolder to the sidebar
  • Adding /Users/sbarex/Documents/MySidebarFolder to Keka's Finder Extension list
  • MySidebarFolder has a bad icon

Workaround:

  • Adding /Users/sbarex/Documents/MySidebarFolder to the sidebar
  • Adding /Users/sbarex/Documents to Keka's Finder Extension list
  • MySidebarFolder has the correct icon

@aonez aonez unpinned this issue Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants