Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font color doesn't change on selecting the options in Preferences->File Access #681

Closed
hpycndl opened this issue Nov 22, 2020 · 1 comment
Assignees
Milestone

Comments

@hpycndl
Copy link

hpycndl commented Nov 22, 2020

Configuration

  • Keka version: [e.g. 1.2.3 (4223)]
  • macOS version: [e.g. 11.0.1]

Describe the bug

I use light mode theme for macos. On File Access tab in Preferences, the location options, when selected, doesn't change color. It gives poor visibility.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Preferences', then 'File Access' tab
  2. Click on any one of the locations in the list under You can also customize the access below
  3. The font color doesn't change to white. Giving bad visibility.

Expected behavior

The font color must change to white for dark background.

Screenshots

Screen Shot 2020-11-22 at 11 23 55 AM

@hpycndl hpycndl added the bug label Nov 22, 2020
@aonez aonez added this to the Look at milestone Nov 22, 2020
@aonez aonez removed the Apple SDK label Nov 22, 2020
@aonez aonez modified the milestones: Look at, 1.2.4 Nov 22, 2020
@aonez
Copy link
Owner

aonez commented Nov 22, 2020

Thanks @hpycndl for that catch! This color was fixed to NSColor.textColor that does not change with Light or Dark modes. Changed to NSColor.controlTextColor for next revision :)

@aonez aonez closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants