Bug in toolbar on dark theme in macOS Big Sur

[Oleg-Chashko]

Configuration

Keka version: 1.2.3 (4223)
macOS version: 11.0.1 (20B29)

On a dark theme in macOS Big Sur, Icon shades bug. I think you forgot to adapt the toolbar to macOS Big Sur.

To Reproduce

Expected behavior
Should be:

[Oleg-Chashko]

The toolbar settings menu is also not adapted to macOS Big Sur.

[aonez]

I'm not sure I understand this one. The unified toolbar uses Big Sur style NSWindowToolbarStyleUnified.

On a dark theme in macOS Big Sur, Icon shades bug. I think you forgot to adapt the toolbar to macOS Big Sur.

Also this one, the settings menu is default and automatically generated. I'm seeing the same one in Finder.

The toolbar settings menu is also not adapted to macOS Big Sur.

Can you share screenshots of what you're seeing and screenshots of some other apps (macOS bundled if possible) that appears different?

[Oleg-Chashko]

I'm not sure I understand this one. The unified toolbar uses Big Sur style NSWindowToolbarStyleUnified.

On a dark theme in macOS Big Sur, Icon shades bug. I think you forgot to adapt the toolbar to macOS Big Sur.

Now such a problem with all icons.

Now icon shade:

Should Icon shade be:

[Oleg-Chashko]

The toolbar settings menu is also not adapted to macOS Big Sur.

Symbols and text - Not ok.
Symbols only - ok.
Only text - Not ok.
Bildschirmaufnahme 2020-11-25 um 11.15.13.zip

[aonez]

Right thanks!

Now such a problem with all icons.

This one I'm facing since Mojave or Catalina. Not sure how to fix it, probably I should implement the format selector in another way.

About the toolbar menu is curios how it changed from Catalina:

[Oleg-Chashko]

Was glad to help!

[aonez]

Already added the proper labels to the buttons, this will come in 1.2.4. Only text will change to text and icon... Probably this can be fixed by not using custom views, that also may fix the icons color, but this is probably a more difficult fix, if possible.

[Oleg-Chashko]

@aonez
Configuration
Keka version: 1.2.4
macOS version: 11.0.1 (20B29)

Symbols and text - ok.
Symbols only - ok.
Only text - Not ok.

When you select "text only" and click, it switches to "Symbols and text", strange behavior in my opinion.
Better to just remove the "text only".

Bildschirmaufnahme 2020-11-26 um 11.54.06.zip

It could be done like this:

[aonez]

That is quick feedback @Oleg-Chashko! Thanks!!! Yep I've told you here:

Only text will change to text and icon...

There's no way to change the options of that menu. I can get rid of it entirely but like this at least you have some customization right now.

The final fix for that only text option will be using a different object for the format selector.

[Oleg-Chashko]

@aonez
Got it. Thanks for the quick response.
P.S.: Weird why this only happens on macOS Big Sur dark theme?

[aonez]

P.S.: Weird why this only happens on macOS Big Sur dark theme?

The light issue in the icon also appears in Catalina (and I recall Mojave). Dark mode only indeed.

[microfx]

@aonez also everything is brown – could you please change that? It's not looking good... I wish it was blue like every other progress bar – brown is a shty color doesn't look right to me even after having seen it 200 times

[aonez]

@microfx this is a feature in Big Sur, but I'm not happy with the result of it. I'll tweak or remove it in the next release.

You can also disable that feature in macOS Preferences, it is the "Rainbow" accent color:

[microfx]

Awesome! Thanks a lot!

…

Am 13.02.2021 um 18:42 schrieb aONe ***@***.***>:  @microfx this is a feature in Big Sur, but I'm not happy with the result of it. I'll tweak or remove it in the next release. You can also disable that feature in macOS Preferences, it is the "Rainbow" accent color: — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[Oleg-Chashko]

Hopefully they will fix it in macOS updates. :)
Topic closed.

[aonez]

This one I'm not sure, maybe I can fix it. Leaving it open so I can check it in the future.

[Oleg-Chashko]

Ok.