Skip to content

Bug in toolbar on dark theme in macOS Big Sur #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oleg-Chashko opened this issue Nov 24, 2020 · 18 comments
Closed

Bug in toolbar on dark theme in macOS Big Sur #690

Oleg-Chashko opened this issue Nov 24, 2020 · 18 comments
Assignees
Milestone

Comments

@Oleg-Chashko
Copy link
Contributor

Configuration

Keka version: 1.2.3 (4223)
macOS version: 11.0.1 (20B29)

On a dark theme in macOS Big Sur, Icon shades bug. I think you forgot to adapt the toolbar to macOS Big Sur.

To Reproduce
Bildschirmfoto 2020-11-24 um 20 13 18

Expected behavior
Should be:
Bildschirmfoto 2020-11-24 um 20 14 39

@Oleg-Chashko
Copy link
Contributor Author

The toolbar settings menu is also not adapted to macOS Big Sur.
Bildschirmfoto 2020-11-24 um 20 31 41

@aonez aonez added this to the 1.2.4 milestone Nov 25, 2020
@aonez
Copy link
Owner

aonez commented Nov 25, 2020

I'm not sure I understand this one. The unified toolbar uses Big Sur style NSWindowToolbarStyleUnified.

On a dark theme in macOS Big Sur, Icon shades bug. I think you forgot to adapt the toolbar to macOS Big Sur.

Also this one, the settings menu is default and automatically generated. I'm seeing the same one in Finder.

The toolbar settings menu is also not adapted to macOS Big Sur.

Can you share screenshots of what you're seeing and screenshots of some other apps (macOS bundled if possible) that appears different?

@Oleg-Chashko
Copy link
Contributor Author

I'm not sure I understand this one. The unified toolbar uses Big Sur style NSWindowToolbarStyleUnified.

On a dark theme in macOS Big Sur, Icon shades bug. I think you forgot to adapt the toolbar to macOS Big Sur.

Now such a problem with all icons.

Now icon shade:
Bildschirmfoto 2020-11-25 um 10 53 29
Bildschirmfoto 2020-11-25 um 11 08 05

Should Icon shade be:
Bildschirmfoto 2020-11-25 um 10 54 31
Bildschirmfoto 2020-11-25 um 11 06 02

@Oleg-Chashko
Copy link
Contributor Author

The toolbar settings menu is also not adapted to macOS Big Sur.

Symbols and text - Not ok.
Symbols only - ok.
Only text - Not ok.
Bildschirmaufnahme 2020-11-25 um 11.15.13.zip

@aonez aonez added the bug label Nov 25, 2020
@aonez
Copy link
Owner

aonez commented Nov 25, 2020

Right thanks!

Now such a problem with all icons.

This one I'm facing since Mojave or Catalina. Not sure how to fix it, probably I should implement the format selector in another way.

About the toolbar menu is curios how it changed from Catalina:

Screenshot 2020-11-25 at 11 43 28

@aonez aonez modified the milestones: 1.2.4, Look at Nov 25, 2020
@Oleg-Chashko
Copy link
Contributor Author

Was glad to help!

@aonez aonez modified the milestones: Look at, 1.2.5 Nov 25, 2020
@aonez
Copy link
Owner

aonez commented Nov 25, 2020

Already added the proper labels to the buttons, this will come in 1.2.4. Only text will change to text and icon... Probably this can be fixed by not using custom views, that also may fix the icons color, but this is probably a more difficult fix, if possible.

Screenshot 2020-11-25 at 12 07 15

@Oleg-Chashko
Copy link
Contributor Author

@aonez
Configuration
Keka version: 1.2.4
macOS version: 11.0.1 (20B29)

Symbols and text - ok.
Symbols only - ok.
Only text - Not ok.

When you select "text only" and click, it switches to "Symbols and text", strange behavior in my opinion.
Better to just remove the "text only".

Bildschirmaufnahme 2020-11-26 um 11.54.06.zip

It could be done like this:
Bildschirmfoto 2020-11-26 um 12 04 15

@aonez
Copy link
Owner

aonez commented Nov 26, 2020

That is quick feedback @Oleg-Chashko! Thanks!!! Yep I've told you here:

Only text will change to text and icon...

There's no way to change the options of that menu. I can get rid of it entirely but like this at least you have some customization right now.

The final fix for that only text option will be using a different object for the format selector.

@aonez aonez modified the milestones: 1.2.5, 1.3.0 Nov 26, 2020
@Oleg-Chashko
Copy link
Contributor Author

Oleg-Chashko commented Nov 26, 2020

@aonez
Got it. Thanks for the quick response.
P.S.: Weird why this only happens on macOS Big Sur dark theme?

@aonez
Copy link
Owner

aonez commented Nov 26, 2020

P.S.: Weird why this only happens on macOS Big Sur dark theme?

The light issue in the icon also appears in Catalina (and I recall Mojave). Dark mode only indeed.

@microfx
Copy link

microfx commented Feb 12, 2021

@aonez also everything is brown – could you please change that? It's not looking good... I wish it was blue like every other progress bar – brown is a shty color doesn't look right to me even after having seen it 200 times

Bildschirmfoto 2021-02-12 um 23 25 30

@aonez
Copy link
Owner

aonez commented Feb 13, 2021

@microfx this is a feature in Big Sur, but I'm not happy with the result of it. I'll tweak or remove it in the next release.

You can also disable that feature in macOS Preferences, it is the "Rainbow" accent color:

Screenshot 2021-02-13 at 18 41 53

@microfx
Copy link

microfx commented Feb 13, 2021 via email

@Oleg-Chashko
Copy link
Contributor Author

Hopefully they will fix it in macOS updates. :)
Topic closed.

@aonez
Copy link
Owner

aonez commented Nov 25, 2021

This one I'm not sure, maybe I can fix it. Leaving it open so I can check it in the future.

@aonez aonez reopened this Nov 25, 2021
@Oleg-Chashko
Copy link
Contributor Author

Ok.

@aonez aonez modified the milestones: 1.3.0, Apple's May 10, 2023
@aonez
Copy link
Owner

aonez commented May 10, 2023

I'm finally closing this one. As you can see the image color distortion is only applied in the toolbar. I'll fill a bug to Apple but I expect nothing to be made about it.

Screenshot 2023-05-10 at 12 32 10

@aonez aonez closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants