Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Progress bar colour #710

Closed
idleberg opened this issue Dec 1, 2020 · 2 comments
Closed

[BUG] Progress bar colour #710

idleberg opened this issue Dec 1, 2020 · 2 comments
Assignees
Milestone

Comments

@idleberg
Copy link

idleberg commented Dec 1, 2020

Configuration

  • Keka version: 1.2.4 (4287)
  • macOS version: 10.14.6 (18G6032)

Describe the bug

I've noticed a minor detail regarding Keka's progress bar. By default, macOS uses the accent colour specified in the General settings for its progress bars. Keka, however, uses a green one.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'System Preferences' and change the Accent colour in the General settings to anything but green
  2. Compress a file using Keka
  3. Take notice of the progress bar colour

Expected behavior

I'd expect the user preferences to be respected

Screenshots

image

Accent colour is red, progress bar is green

@idleberg idleberg added the bug label Dec 1, 2020
@aonez aonez added the gui label Dec 1, 2020
@aonez aonez added this to the Look at milestone Dec 1, 2020
@aonez
Copy link
Owner

aonez commented Dec 1, 2020

Thanks for that one @idleberg, had a friend commenting me about those colours but was unsure how he got them.

Keka 1.2.0 uses custom colours for known formats but it seems it only shows the correct colour when the accent colour is set to blue. If you create an ISO/DMG you'll see your accent colour.

I'll see what can I do with that.

@aonez aonez modified the milestones: Look at, 1.2.5 Dec 1, 2020
@aonez
Copy link
Owner

aonez commented Dec 1, 2020

Keka will only use custom color when blue accent color is selected. Here a build with that fixed: Keka-v1.2.5-r4305

@aonez aonez added the fixed label Dec 1, 2020
@aonez aonez closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants