New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plzip instead of lzip #75

Open
aonez opened this Issue Sep 13, 2017 · 4 comments

Comments

2 participants
@aonez
Owner

aonez commented Sep 13, 2017

A continuation of #68.
For better speed compression and extraction, use multithreaded plzip instead of lzip.

  • Binary must pause when asked
  • Percentage progress must update

Since version 1.1.0-beta.3r2194, you can enable plzip:

defaults write com.aone.Keka UseMultithreadLzip <true|false>

@aonez aonez added this to the Future milestone Sep 13, 2017

@aonez aonez self-assigned this Sep 13, 2017

@aonez aonez modified the milestones: Future, 1.1.0 Sep 26, 2017

@aonez aonez modified the milestones: 1.1.0, 1.1.1 Oct 16, 2017

@MaxPower85

This comment has been minimized.

MaxPower85 commented Mar 22, 2018

It doesn't seem like Keka is using plzip even with defaults write com.aone.Keka UseMultithreadLzip true

Even after restarting Keka... for .lz format it seems that only lzip is used... Activity Monitor shows kekalzip using a single thread... both when compressing a single file or multiple files...

I've tested plzip in Terminal and even with it's default settings it used multithreading and it was significantly faster than lzip Keka uses... it was also faster for decompressing .lz archives.

BTW... the progress bar in Keka isn't moving when you compress a single file to .lz format... it moves only when compressing multiple files.

I tried to open the Resources folder and to rename kekaplzip to kekalzip, to see if Keka would use it... and it seems to be working really well... after renaming it, Keka uses multithreading for .lz format... also, the progress bar for single files also seems to be working fine when plzip is used and it seems to be more accurate that the progress bar for multiple files.

So... just use plzip instead of lzip... and see if you can make the progress bar have the same behavior for multiple files too as it does for single files, since the progress bar seems to be working fine for single files when plzip is used.

@aonez

This comment has been minimized.

Owner

aonez commented Mar 22, 2018

Even after restarting Keka... for .lz format it seems that only lzip is used... Activity Monitor shows kekalzip using a single thread... both when compressing a single file or multiple files...

I don't know why this is happening. It works on debug.

@aonez

This comment has been minimized.

Owner

aonez commented Mar 22, 2018

Really strange thing, the key seems to be deleted:

aONe-Mini:~ aone$ defaults read com.aone.Keka UseMultithreadLzip
2018-03-22 11:05:38.178 defaults[66713:671214] 
The domain/default pair of (com.aone.Keka, UseMultithreadLzip) does not exist

It's the cached thing of the user defaults...

@aonez

This comment has been minimized.

Owner

aonez commented Mar 22, 2018

BTW... the progress bar in Keka isn't moving when you compress a single file to .lz format... it moves only when compressing multiple files.

Fixed that for next revision.

aonez added a commit that referenced this issue Apr 12, 2018

@aonez aonez modified the milestones: 1.1.1, 1.1.2 Jun 13, 2018

@aonez aonez modified the milestones: 1.1.2, 1.1.3 Jun 22, 2018

@aonez aonez modified the milestones: 1.1.3, 1.1.4 Aug 9, 2018

@aonez aonez modified the milestones: 1.1.4, 1.2.0 Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment