Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English translation improvements #167

Merged
merged 3 commits into from Apr 5, 2018
Merged

English translation improvements #167

merged 3 commits into from Apr 5, 2018

Conversation

@gingerbeardman
Copy link
Contributor

@gingerbeardman gingerbeardman commented Apr 4, 2018

As for GitHub reporting some of the .strings file as Binary, I think it's a bug/feature their end. But still I added some mitigations in this PR.

  • .gitattributes
  • .gitconfig
  • all English (& Polish because GitHub app) .strings files as UTF-8 with BOM

The "Electron" GitHub Desktop app shows them as Binary.
The GitHub website shows them as Binary.

The "Classic" GitHub Desktop app shows them as Text.

@aonez aonez merged commit 35bd3b5 into aonez:master Apr 5, 2018
@aonez aonez self-assigned this Apr 5, 2018
@aonez aonez added this to the 1.1.0 milestone Apr 5, 2018
@aonez
Copy link
Owner

@aonez aonez commented Apr 5, 2018

It seems all the problem was using UTF-16 in some files. Converting them to UTF-8 fixes the issue, apparently no .gitconfig needed. Will push an update now with all converted and a script to auto convert them (I'll be using it in the build process).

@aonez
Copy link
Owner

@aonez aonez commented Apr 5, 2018

I'll leave the .gitconfig in case is needed for any of those apps you've named. I'm currently using (and mostly loving) Fork, and this config seems not necessary there or in the website.

@gingerbeardman
Copy link
Contributor Author

@gingerbeardman gingerbeardman commented Apr 5, 2018

I don't think the .gitconfig is needed if you're including UTF-8 conversion elsewhere.

I'll check out Fork! New GitHub Desktop is a real step back.

aonez added a commit that referenced this issue Oct 14, 2019
English translation improvements
aonez added a commit that referenced this issue Oct 14, 2019
English translation improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants