Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to texts #372

Merged
merged 7 commits into from Jun 21, 2019

Conversation

Projects
None yet
3 participants
@anosidium
Copy link
Contributor

commented Feb 22, 2019

No description provided.

anosidium and others added some commits Feb 22, 2019

Update README.md
Added question marks.
@anosidium

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

British English Localisation.

@gingerbeardman

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

Some of this doesn't read well. No better than the original text. eg. What is more to do here?

And please make sure to capitalise terms the same way as macOS, eg. bin -> Bin

I have not read all changes.

Update preferences.strings
Capitalised bin to Bin.
@anosidium

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Punctuations are important. It may not be significant but it improve the clarity. Maybe that one could be dismissed but this one is important.

So, where is the source code

is a question and therefore requires a question mark.

I have updated the capitalisation of the word bin to Bin.

@aonez aonez self-assigned this Mar 4, 2019

@aonez

This comment has been minimized.

Copy link
Owner

commented Jun 19, 2019

@anosidium, please remove the README changes so I can merge the en-GB.lproj

@aonez aonez added this to the 1.1.17 milestone Jun 19, 2019

@aonez
Copy link
Owner

left a comment

Please remove the README changes

Delete README.md
I was asked to remove the README.md.
@anosidium

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

Done! By the way, macOS Catalina have a better English localisation. The Trash has been renamed to Bin.

@aonez aonez merged commit 135e8ba into aonez:master Jun 21, 2019

@aonez

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2019

Thanks @anosidium! The pull needed some tweaking, there were some strings removed and some comments and keys translated. Maintenance should be pretty easy from now on 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.