Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to texts #372

Merged
merged 7 commits into from Jun 21, 2019
Merged

Minor changes to texts #372

merged 7 commits into from Jun 21, 2019

Conversation

@anosidium
Copy link
Contributor

@anosidium anosidium commented Feb 22, 2019

No description provided.

@anosidium
Copy link
Contributor Author

@anosidium anosidium commented Feb 22, 2019

British English Localisation.

@gingerbeardman
Copy link
Contributor

@gingerbeardman gingerbeardman commented Feb 22, 2019

Some of this doesn't read well. No better than the original text. eg. What is more to do here?

And please make sure to capitalise terms the same way as macOS, eg. bin -> Bin

I have not read all changes.

Capitalised bin to Bin.
@anosidium
Copy link
Contributor Author

@anosidium anosidium commented Feb 22, 2019

Punctuations are important. It may not be significant but it improve the clarity. Maybe that one could be dismissed but this one is important.

So, where is the source code

is a question and therefore requires a question mark.

I have updated the capitalisation of the word bin to Bin.

@aonez
Copy link
Owner

@aonez aonez commented Jun 19, 2019

@anosidium, please remove the README changes so I can merge the en-GB.lproj

@aonez aonez added this to the 1.1.17 milestone Jun 19, 2019
Copy link
Owner

@aonez aonez left a comment

Please remove the README changes

I was asked to remove the README.md.
@anosidium
Copy link
Contributor Author

@anosidium anosidium commented Jun 19, 2019

Done! By the way, macOS Catalina have a better English localisation. The Trash has been renamed to Bin.

@aonez aonez merged commit 135e8ba into aonez:master Jun 21, 2019
@aonez
Copy link
Owner

@aonez aonez commented Jun 21, 2019

Thanks @anosidium! The pull needed some tweaking, there were some strings removed and some comments and keys translated. Maintenance should be pretty easy from now on 😊

aonez added a commit that referenced this issue Sep 2, 2019
#433 Thanks to @maxsky for the tip
It was mistakenly removed here #372
aonez added a commit that referenced this issue Oct 14, 2019
aonez added a commit that referenced this issue Oct 14, 2019
#433 Thanks to @maxsky for the tip
It was mistakenly removed here #372
aonez added a commit that referenced this issue Oct 14, 2019
aonez added a commit that referenced this issue Oct 14, 2019
#433 Thanks to @maxsky for the tip
It was mistakenly removed here #372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants