Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos, adjusted width #487

Merged
merged 1 commit into from Nov 21, 2019
Merged

Fixed typos, adjusted width #487

merged 1 commit into from Nov 21, 2019

Conversation

@lFenix
Copy link
Contributor

lFenix commented Nov 21, 2019

Fixed problems in #486

@aonez aonez self-assigned this Nov 21, 2019
@aonez aonez added this to the 1.1.23 milestone Nov 21, 2019
@aonez aonez merged commit c1bf750 into aonez:master Nov 21, 2019
@aonez

This comment has been minimized.

Copy link
Owner

aonez commented Nov 21, 2019

Thanks again @lFenix! There you have the build: Keka-Czech-r2.7z

@lFenix

This comment has been minimized.

Copy link
Contributor Author

lFenix commented Nov 21, 2019

Thanks for the build again 😊 Can I have another request?

What's the ID of this dropdown?
image

I thought I've already fixed the grammar mistake in it in the last commit, but apparently not 😩

@aonez

This comment has been minimized.

Copy link
Owner

aonez commented Nov 21, 2019

Those two are the compression and extraction items. The IDs are automatically generated.

https://github.com/lFenix/Keka/blob/c390e8a9e34f589ed7798346ca9e35b7cec9396d/Translations/cs.lproj/preferences.strings#L71-L78

/* Class = "NSMenuItem"; title = "Ask each time"; ObjectID = "279"; */
"279.title" = "Pokaždé se zeptat";
/* Class = "NSMenuItem"; title = "Next to original file"; ObjectID = "280"; */
"280.title" = "Stejná, jako výchozí soubory";
/* Class = "NSMenuItem"; title = "Custom folder..."; ObjectID = "281"; */
"281.title" = "Vybrat složku...";

https://github.com/lFenix/Keka/blob/c390e8a9e34f589ed7798346ca9e35b7cec9396d/Translations/cs.lproj/preferences.strings#L113-L120

/* Class = "NSMenuItem"; title = "Ask each time"; ObjectID = "357"; */
"357.title" = "Pokaždé se zeptat";
/* Class = "NSMenuItem"; title = "Next to original file"; ObjectID = "358"; */
"358.title" = "Stejné, jako výchozí soubory";
/* Class = "NSMenuItem"; title = "Custom folder..."; ObjectID = "359"; */
"359.title" = "Vlastní cesta...";

@lFenix

This comment has been minimized.

Copy link
Contributor Author

lFenix commented Nov 21, 2019

Thank you again, that finally fixed it 😊 I also found out how to test the localization on my machine, so I will no longer spam you with build requests 😅

I'll open one more pull request, and that should be it for this release

@aonez

This comment has been minimized.

Copy link
Owner

aonez commented Nov 21, 2019

I also found out how to test the localization on my machine

Yeah maybe resigning it should be enough 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.