Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Russian translation of the app #642

Merged
merged 12 commits into from Oct 5, 2020
Merged

Update the Russian translation of the app #642

merged 12 commits into from Oct 5, 2020

Conversation

kytta
Copy link
Contributor

@kytta kytta commented Oct 2, 2020

Back when I did the Russian translation, I did it quite hastily, and now have discovered some mistakes. I have also fixed some mistakes other Russian translators may have done.

Don't fear the abundance of commits — I have decided to break them apart for each individual type of change for a better description of it and an easier rollback, if necessary :) You can squash the commits when merging this I can do it for you and overwrite the already pushed commits, no biggie

Things changed in this PR:

  • some strings had a Cyrillic version of the name "Keka" — made sure the English one is used everywhere
  • shortened lots of strings
    • this way they're easier to read
    • this also compensates the fact that Russian words can be very long
  • translated strings that were left untranslated
  • fixed punctuation and orthography errors
  • updated my website (since I have a new domain now)

P.S. I just noticed that Oleg had opened a similar PR (#644); it's similar to what I did, just to a lesser extent and also with some questionable punctuation (no offence whatsoever). Idk how to resolve both of the PRs without causing git conflicts and translation inconsistency 🤔

kytta added 12 commits Oct 4, 2020
This increases the readability; the text becomes easier to understand
This includes stuff like punctuation, capitalization and sentence building
It doesn't really clarify the translations, but the end text looks and sounds better
- "Разбивка..." ("Splitting...") became "Разбить..." ("Split")
- "...образа диска" ("Disk image...") became "...образа" ("Image..." / "Volume...")
In accordance to the rules of Russian
@kytta kytta marked this pull request as ready for review Oct 4, 2020
@aonez
Copy link
Owner

aonez commented Oct 5, 2020

I'm merging this one first since it came before. Will check then with @Oleg-Chashko :)

@aonez aonez self-assigned this Oct 5, 2020
@aonez aonez added this to the 1.2.0 milestone Oct 5, 2020
@aonez
Copy link
Owner

aonez commented Oct 5, 2020

  • some strings had a Cyrillic version of the name "Keka"

By the way thanks for that one and cool new domain 😉

@aonez aonez mentioned this pull request Oct 5, 2020
@aonez aonez merged commit f2f84aa into aonez:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants