including the last inserted row id if available - #5
Merged
Conversation
aosingh
requested changes
Dec 28, 2020
aosingh
left a comment
Owner
There was a problem hiding this comment.
Thank you for creating a pull request.
We could simplify the code and remove variables lastrowid and ret
As documented here, lastrowid is either set or it is None. So, something like this would be simple.
if self._cursor.lastrowid:
result['lastrowid'] = self._cursor.lastrowid
Contributor
Author
|
Great suggestion @aosingh thanks for reviewing the PR. I just implemented the change you requested. Feel free to let me know if something more is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it very useful to have the id of the last row that has just been inserted.
Before this change, executing
insertquery would result in something of the formafter this change we get something like