Navigation Menu

Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

Commit

Permalink
Merge change 4526 into donut
Browse files Browse the repository at this point in the history
* changes:
  Log null author command in authordriver.cpp (bug 1922537) Note this does not resolve the root cause for the mediaserver crash reported in bug 1922537: 1. why was a null author command received from the author engine (PV is looking into this issue)? 2. why was the time stamp out of the order (QCOM and PV are looking into this issue)? 3. why did we receive multiple event callbacks for a single state transition request (QCOM is looking into this issue)?
  • Loading branch information
Android (Google) Code Review committed Jun 18, 2009
2 parents 5aa579d + 2c5955b commit d84d033
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion android/author/authordriver.cpp
Expand Up @@ -1100,7 +1100,11 @@ void AuthorDriver::CommandCompleted(const PVCmdResponse& aResponse)
{
author_command *ac = (author_command *)aResponse.GetContext();
status_t s = aResponse.GetCmdStatus();
LOGV("Command (%d) completed with status(%d)", ac->which, s);
LOGV("Command (%d) completed with status(%d)", ac? ac->which: -1, s);
if (ac == NULL) {
LOGE("CommandCompleted: Error - null author command!");
return;
}

if (ac->which == AUTHOR_SET_OUTPUT_FORMAT) {
mSelectedComposer = aResponse.GetResponseData();
Expand Down

0 comments on commit d84d033

Please sign in to comment.