Start enforcing javac warnings.

- Add new ways to ignore warnings for modules with warnings
- Enable -Xlint:deprecation and -Xlint:unchecked by default to
  prevent regressions.

Test: ./gradlew assembleDebug
Change-Id: I95f73afde042a2d61984f59ee3d3350a013c0044
Merged-In: I95f73afde042a2d61984f59ee3d3350a013c0044

buildSrc/src/main/kotlin/androidx/build/SupportAndroidLibraryPlugin.kt

@@ -65,6 +65,20 @@ class SupportAndroidLibraryPlugin : Plugin<Project> {
 
             VersionFileWriterTask.setUpAndroidLibrary(project, library)
             DiffAndDocs.registerAndroidProject(project, library, supportLibraryExtension)
+
+            library.libraryVariants.all { libraryVariant ->
+                if (libraryVariant.getBuildType().getName().equals("debug")) {
+                    @Suppress("DEPRECATION")
+                    val javaCompile = libraryVariant.javaCompile
+                    if (supportLibraryExtension.failOnUncheckedWarnings) {
+                        javaCompile.options.compilerArgs.add("-Xlint:unchecked")
+                    }
+                    if (supportLibraryExtension.failOnDeprecationWarnings) {
+                        javaCompile.options.compilerArgs.add("-Xlint:deprecation")
+                    }
+                    javaCompile.options.compilerArgs.add("-Werror")
+                }
+            }
         }
 
         project.apply(mapOf("plugin" to "com.android.library"))

buildSrc/src/main/kotlin/androidx/build/SupportLibraryExtension.kt

@@ -34,6 +34,9 @@ open class SupportLibraryExtension(val project: Project) {
     private var licenses: MutableCollection<License> = ArrayList()
     var java8Library = false
     var publish = false
+    var failOnUncheckedWarnings = true
+    var failOnDeprecationWarnings = true
+
     /**
      * This flag works only if publish flag is "true".
      * It is useful for modules that are used for tooling. For example room annotation

car/build.gradle

@@ -54,4 +54,5 @@ supportLibrary {
     description = "Android Car Support UI"
     java8Library = true
     minSdkVersion = 24
+    failOnUncheckedWarnings = false
 }

cardview/build.gradle.kts

@@ -20,4 +20,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.CARDVIEW
     inceptionYear = "2011"
     description = "Android Support CardView v7"
+    failOnDeprecationWarnings = false
 }

compat/build.gradle

@@ -37,4 +37,6 @@ supportLibrary {
     mavenGroup = LibraryGroups.CORE
     inceptionYear = "2015"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren\'t a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

content/build.gradle.kts

@@ -41,4 +41,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.CONTENTPAGING
     inceptionYear = "2017"
     description = "Library providing support for paging across content exposed via a ContentProvider. Use of this library allows a client to avoid expensive interprocess \"cursor window swaps\" on the UI thread."
+    failOnDeprecationWarnings = false
 }

coordinatorlayout/build.gradle.kts

@@ -36,4 +36,6 @@ supportLibrary {
     mavenGroup = LibraryGroups.COORDINATORLAYOUT
     inceptionYear = "2011"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren't a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

cursoradapter/build.gradle

@@ -16,4 +16,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.CURSORADAPTER
     inceptionYear = "2018"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren't a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnDeprecationWarnings = false
 }

customview/build.gradle

@@ -22,4 +22,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.CUSTOMVIEW
     inceptionYear = "2018"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren't a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnDeprecationWarnings = false
 }

dynamic-animation/build.gradle

@@ -24,4 +24,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.DYNAMICANIMATION
     inceptionYear = "2017"
     description = "Physics-based animation in support library, where the animations are driven by physics force. You can use this Animation library to create smooth and realistic animations."
+    failOnUncheckedWarnings = false
 }

fragment/build.gradle

@@ -30,4 +30,6 @@ supportLibrary {
     mavenGroup = LibraryGroups.FRAGMENT
     inceptionYear = "2011"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren\'t a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

graphics/drawable/static/build.gradle

@@ -31,4 +31,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.VECTORDRAWABLE
     inceptionYear = "2015"
     description = "Android Support VectorDrawable"
+    failOnDeprecationWarnings = false
 }

gridlayout/build.gradle

@@ -21,4 +21,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.GRIDLAYOUT
     inceptionYear = "2013"
     description = "Android Support Grid Layout"
+    failOnDeprecationWarnings = false
 }

leanback-preference/build.gradle

@@ -30,4 +30,5 @@ supportLibrary {
     inceptionYear = "2015"
     description = "Android Support Leanback Preference v17"
     minSdkVersion = 17
+    failOnDeprecationWarnings = false
 }

leanback/build.gradle

@@ -37,4 +37,6 @@ supportLibrary {
     inceptionYear = "2014"
     description = "Android Support Leanback v17"
     minSdkVersion = 17
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

legacy/v13/build.gradle

@@ -16,4 +16,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.LEGACY
     inceptionYear = "2011"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren't a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnDeprecationWarnings = false
 }

lifecycle/extensions/build.gradle

@@ -55,4 +55,5 @@ supportLibrary {
     inceptionYear = "2017"
     description = "Android Lifecycle Extensions"
     url = SupportLibraryExtension.ARCHITECTURE_URL
+    failOnDeprecationWarnings = false
 }

lifecycle/livedata-core/build.gradle

@@ -42,4 +42,5 @@ supportLibrary {
     inceptionYear = "2017"
     description = "Android Lifecycle LiveData Core"
     url = SupportLibraryExtension.ARCHITECTURE_URL
+    failOnUncheckedWarnings = false
 }

lifecycle/runtime/build.gradle

@@ -34,4 +34,5 @@ supportLibrary {
     inceptionYear '2017'
     description "Android Lifecycle Runtime"
     url SupportLibraryExtension.ARCHITECTURE_URL
+    failOnDeprecationWarnings = false
 }

lifecycle/viewmodel/build.gradle

@@ -44,4 +44,5 @@ supportLibrary {
     inceptionYear = "2017"
     description = "Android Lifecycle ViewModel"
     url = SupportLibraryExtension.ARCHITECTURE_URL
+    failOnUncheckedWarnings = false
 }

loader/build.gradle

@@ -25,4 +25,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.LOADER
     inceptionYear = "2011"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren\'t a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnUncheckedWarnings = false
 }

media/build.gradle

@@ -41,4 +41,6 @@ supportLibrary {
     mavenGroup = LibraryGroups.MEDIA
     inceptionYear = "2011"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren't a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

media/version-compat-tests/lib/build.gradle

@@ -23,3 +23,7 @@ plugins {
 dependencies {
     implementation(JUNIT)
 }
+
+supportLibrary {
+    failOnUncheckedWarnings = false
+}

mediarouter/build.gradle

@@ -34,4 +34,6 @@ supportLibrary {
     mavenGroup = LibraryGroups.MEDIAROUTER
     inceptionYear = "2013"
     description = "Android MediaRouter Support Library"
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

paging/runtime/build.gradle

@@ -48,4 +48,5 @@ supportLibrary {
     inceptionYear = "2017"
     description = "Android Paging-Runtime"
     url = SupportLibraryExtension.ARCHITECTURE_URL
+    failOnUncheckedWarnings = false
 }

paging/rxjava2/build.gradle

@@ -45,4 +45,5 @@ supportLibrary {
     inceptionYear = "2018"
     description = "Android Paging RXJava2"
     url = SupportLibraryExtension.ARCHITECTURE_URL
+    failOnUncheckedWarnings = false
 }

preference/build.gradle

@@ -55,4 +55,6 @@ supportLibrary {
     mavenGroup = LibraryGroups.PREFERENCE
     inceptionYear = "2015"
     description = "Android Support Preference v7"
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

print/build.gradle

@@ -16,4 +16,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.PRINT
     inceptionYear = "2018"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren't a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnDeprecationWarnings = false
 }

recommendation/build.gradle

@@ -17,4 +17,5 @@ supportLibrary {
     inceptionYear = "2015"
     description = "Android Support Recommendation"
     minSdkVersion = 21
+    failOnDeprecationWarnings = false
 }

recyclerview-selection/build.gradle

@@ -41,4 +41,6 @@ supportLibrary {
     mavenGroup = LibraryGroups.RECYCLERVIEW
     inceptionYear = "2017"
     description = "Library providing item selection framework for RecyclerView. Support for touch based and band selection is provided."
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

slices/builders/build.gradle

@@ -36,4 +36,5 @@ supportLibrary {
     inceptionYear = "2017"
     description = "A set of builders to create templates using SliceProvider APIs"
     minSdkVersion = 19
+    failOnUncheckedWarnings = false
 }

slices/core/build.gradle

@@ -40,4 +40,6 @@ supportLibrary {
     inceptionYear = "2017"
     description = "The slices core library provides utilities for the slices view and provider libraries"
     minSdkVersion = 19
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

slices/view/build.gradle

@@ -34,9 +34,6 @@ dependencies {
     androidTestImplementation(DEXMAKER_MOCKITO, libs.exclude_bytebuddy)
 }
 
-android {
-}
-
 supportLibrary {
     name = "Slice views"
     publish = true
@@ -45,4 +42,6 @@ supportLibrary {
     inceptionYear = "2017"
     description = "A library that handles rendering of slice content into supported templates"
     minSdkVersion = 19
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

testutils/build.gradle

@@ -36,3 +36,7 @@ android {
         disable 'InvalidPackage' // Lint is unhappy about junit package
     }
 }
+
+supportLibrary {
+    failOnUncheckedWarnings = false
+}

textclassifier/build.gradle

@@ -24,4 +24,5 @@ supportLibrary {
     inceptionYear = "2018"
     description = "The TextClassifier Support Library can be added to an Android application in order to use the TextClassifier API introduced in Android O on all devices with API level 14 or later."
     minSdkVersion = 14
+    failOnUncheckedWarnings = false
 }

transition/build.gradle

@@ -36,4 +36,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.TRANSITION
     inceptionYear = "2016"
     description = "Android Transition Support Library"
+    failOnDeprecationWarnings = false
 }

tv-provider/build.gradle

@@ -23,4 +23,6 @@ supportLibrary {
     inceptionYear = "2017"
     description = "Android Support Library for TV Provider"
     minSdkVersion = 21
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

v7/appcompat/build.gradle

@@ -53,4 +53,6 @@ supportLibrary {
     mavenGroup = LibraryGroups.APPCOMPAT
     inceptionYear = "2011"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren\'t a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

v7/recyclerview/build.gradle

@@ -42,4 +42,6 @@ supportLibrary {
     mavenGroup = LibraryGroups.RECYCLERVIEW
     inceptionYear = "2014"
     description = "Android Support RecyclerView v7"
+    failOnUncheckedWarnings = false
+    failOnDeprecationWarnings = false
 }

viewpager/build.gradle.kts

@@ -24,4 +24,5 @@ supportLibrary {
     mavenGroup = LibraryGroups.VIEWPAGER
     inceptionYear = "2018"
     description = "The Support Library is a static library that you can add to your Android application in order to use APIs that are either not available for older platform versions or utility APIs that aren't a part of the framework APIs. Compatible on devices running API 14 or later."
+    failOnDeprecationWarnings = false
 }

wear/build.gradle

@@ -42,4 +42,5 @@ supportLibrary {
     inceptionYear = "2016"
     description = "Android Wear Support UI"
     minSdkVersion = 23
+    failOnDeprecationWarnings = false
 }