Permalink
Browse files

upload: Allow review.HOST.username to override email

Some users might need to use a different login name than the local
part of their email address for their Gerrit Code Review user
account.  Allow it to be overridden with the review.HOST.username
configuration variable.

Change-Id: I714469142ac7feadf09fee9c26680c0e09076b75
Signed-off-by: Shawn O. Pearce <sop@google.com>
  • Loading branch information...
spearce committed Jul 16, 2010
1 parent a5ece0e commit 3575b8f8bdc5f15de23db82499e0ce152f634a19
Showing with 9 additions and 1 deletion.
  1. +4 −1 git_config.py
  2. +5 −0 subcmds/upload.py
View
@@ -531,8 +531,11 @@ def ReviewProtocol(self):
def SshReviewUrl(self, userEmail):
if self.ReviewProtocol != 'ssh':
return None
+ username = self._config.GetString('review.%s.username' % self.review)
+ if username is None:
+ username = userEmail.split("@")[0]
return 'ssh://%s@%s:%s/%s' % (
- userEmail.split("@")[0],
+ username,
self._review_host,
self._review_port,
self.projectname)
View
@@ -92,6 +92,11 @@ class Upload(InteractiveCommand):
who you always want copied on all uploads with a non-empty --re
argument.
+review.URL.username:
+
+Override the username used to connect to Gerrit Code Review.
+By default the local part of the email address is used.
+
The URL must match the review URL listed in the manifest XML file,
or in the .git/config within the project. For example:

0 comments on commit 3575b8f

Please sign in to comment.