Permalink
Commits on Aug 22, 2011
  1. merged branch igorw/eventdispatcher-license (PR #1997)

    Commits
    -------
    
    8d48cea [EventDispatcher] Change the license of EventDispatcher from LGPL to MIT
    
    Discussion
    ----------
    
    [EventDispatcher] Change the license of EventDispatcher from LGPL to MIT
    
    It was previously agreed to re-license the Doctrine2 based
    EventDispatcher refactoring to use the MIT license. However, the files
    still retain the LGPL license notice.
    
    This commit changes the license to MIT.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/08/21 05:55:00 -0700
    
    That's right but I would prefer that the PR comes from someone of the Doctrine core team like @beberlei or @jwage.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/08/21 05:55:28 -0700
    
    or at least, they can perhaps acknowledge this PR.
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2011/08/22 00:11:20 -0700
    
    Acknowledged
    fabpot committed Aug 22, 2011
  2. merged branch stloyd/numbertype_test (PR #2001)

    Commits
    -------
    
    933c5aa [Tests] Added missing test for NumberType
    
    Discussion
    ----------
    
    [Tests] Added missing test for NumberType
    fabpot committed Aug 22, 2011
  3. [Yaml] made a small optimization

    fabpot committed Aug 22, 2011
Commits on Aug 21, 2011
  1. [EventDispatcher] Change the license of EventDispatcher from LGPL to MIT

    It was previously agreed to re-license the Doctrine2 based
    EventDispatcher refactoring to use the MIT license. However, the files
    still retain the LGPL license notice.
    
    This commit changes the license to MIT.
    igorw committed Aug 21, 2011
  2. merged branch jayrulez/master (PR #1996)

    Commits
    -------
    
    72d71b5 Cleaned up unused code in Symfony\Component\EventDispatcher\EventDispatcher::getListeners()
    
    Discussion
    ----------
    
    Cleaned up unused code
    
    Cleaned up unused code in Symfony\Component\EventDispatcher\EventDispatcher::getListeners()
    fabpot committed Aug 21, 2011
Commits on Aug 20, 2011
  1. Cleaned up unused code in Symfony\Component\EventDispatcher\EventDisp…

    …atcher::getListeners()
    jayrulez committed Aug 20, 2011
Commits on Aug 19, 2011
  1. merged branch stloyd/form_datetime_transformer (PR #1851)

    Commits
    -------
    
    d880db2 [Form] Test covered fix for invalid date (13 month/31.02.2011 etc.) send to transformer. Closes #1755
    df74f49 Patched src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToArrayTransformer.php to throw an exception when an invalid date is passed for transformation (e.g. 31st February)
    
    Discussion
    ----------
    
    [Form] Fix for "DateTimeToArrayTransformer" with invalid dates
    
    Hey,
    
    this is test covered fix from @mdavis1982 (closes #1755)
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/08/16 01:31:32 -0700
    
    @fabpot Can we have this fix merged ?
    fabpot committed Aug 19, 2011
  2. merged branch martinmayer/session_saving (PR #1937)

    Commits
    -------
    
    34a1b53 [HttpFoundation] Do not save session in Session::__destroy() when saved already
    
    Discussion
    ----------
    
    [HttpFoundation] Saving session data in __destroy() has a side effect on functional tests
    
    Having functional test with several non-insulated requests, TestSessionListener invokes session saving at the end of every request. But instance of Session remains in memory until it's collected by garbage collector which saves the same data again in __destroy() method. The problem is that session object can get collected after other requests changed session data (e. g. user logged in) resulting in former data overwriting the latter.
    fabpot committed Aug 19, 2011
  3. merged branch schmittjoh/visibilityChange (PR #1977)

    Commits
    -------
    
    3dcb238 increased visibility of httpUtils property
    
    Discussion
    ----------
    
    increased visibility of httpUtils property
    fabpot committed Aug 19, 2011
  4. merged branch schmittjoh/requestMethodOverrideFix (PR #1980)

    Commits
    -------
    
    a1d9fed updated tests
    b6ee1a6 fixes a bug when overriding method via the X-HTTP-METHOD-OVERRIDE header
    
    Discussion
    ----------
    
    Request method override fix
    fabpot committed Aug 19, 2011
  5. merged branch hidenorigoto/validator_pattern_late_static_bind (PR #1914)

    Commits
    -------
    
    275da0d [Validator] changed 'self' to 'static' for child class to override pattern constant
    
    Discussion
    ----------
    
    [Validator] change 'self::' to 'static::' for PATTERN constant overridable in child classes
    
    In TimeValidator and UrlValidator, PATTERN constant is not used with late static bind(static::) while DateValidator supports it.
    fabpot committed Aug 19, 2011
  6. merged branch Gregwar/email_guessing (PR #1970)

    Commits
    -------
    
    80d1718 [Fix] Email() constraints now guess as 'email' field type
    
    Discussion
    ----------
    
    [Fix] Email() constraints now guess as 'email' field type
    
    I don't know what this was set to "text"
    fabpot committed Aug 19, 2011
  7. merged branch stloyd/patch-1 (PR #1988)

    Commits
    -------
    
    6e7c375 [FrameworkBundle] Cleanup schema file
    
    Discussion
    ----------
    
    [FrameworkBundle] Cleanup schema file a bit
    
    Removed unused attributes, and added one missing.
    fabpot committed Aug 19, 2011
Commits on Aug 18, 2011
  1. merged branch lsmith77/create_from_globals_tests (PR #1983)

    Commits
    -------
    
    8c9ccf6 added more tests for Request::createFromGlobals()
    
    Discussion
    ----------
    
    added more tests for Request::createFromGlobals()
    fabpot committed Aug 18, 2011
  2. updated tests

    schmittjoh committed Aug 18, 2011
  3. merged branch vicb/HttpKernel/Tests (PR #1978)

    Commits
    -------
    
    1518a81 [HttpKernel] Simplify test code
    
    Discussion
    ----------
    
    [HttpKernel] Simplify test code
    
    Get the `$request` from the client (removes a hack in test kernel)
    fabpot committed Aug 18, 2011
  4. merged branch vicb/SecurityBundle/Tests/autoload (PR #1979)

    Commits
    -------
    
    1515912 [SecurityBundle] Fix autoloading in tests (autoload.php overrides autoload.php.dist when it exists)
    
    Discussion
    ----------
    
    [SecurityBundle] Fix autoloading in tests
    
    autoload.php should override autoload.php.dist when it exists
    fabpot committed Aug 18, 2011
  5. [HttpKernel] Simplify test code

    vicb committed Aug 18, 2011
  6. [SecurityBundle] Fix autoloading in tests (autoload.php overrides aut…

    …oload.php.dist when it exists)
    vicb committed Aug 18, 2011
Commits on Aug 16, 2011
  1. [Fix] Email() constraints now guess as 'email' field type

    Grégoire Passault committed Aug 16, 2011
Commits on Aug 14, 2011
  1. merged branch krmcbride/form-doc-fixes (PR #1959)

    Commits
    -------
    
    e3cb39d [Form] Fixed a few PHPDoc comments
    
    Discussion
    ----------
    
    [Form] Fixed a few PHPDoc comments
    fabpot committed Aug 14, 2011
  2. merged branch pylebecq/master (PR #1958)

    Commits
    -------
    
    e88ecbb [Form] Fixed a typo in AbstractType phpdoc
    
    Discussion
    ----------
    
    [Form] Fixed a typo in AbstractType phpdoc
    
    This PR is a new version of PR #1862.
    
    Original comment :
    Hi,
    Nothing really awesome, but I fixed a typo in some phpdoc of the AbstractType class.
    fabpot committed Aug 14, 2011
  3. merged branch aboks/acl_voter (PR #1954)

    Commits
    -------
    
    09c41d3 [Security] Fixed incorrect merge of two modifications (53f5c23 and 8519967) to AclVoter
    
    Discussion
    ----------
    
    [Security] Fixed incorrect merge of two modifications to AclVoter
    
    It seems two modifications to `AclVoter` (53f5c23 and 8519967) have been merged incorrectly, leading to a method call on an object that is known to be `null` and a fatal error when running the tests
    fabpot committed Aug 14, 2011
Commits on Aug 13, 2011
  1. Revert "expanded namespaces within phpdoc (special for PhpStorm)"

    This reverts commit 6e7439e.
    fabpot committed Aug 13, 2011
  2. merged branch lenar/content-length (PR #1955)

    Commits
    -------
    
    805a267 Remove Content-Length header adding for now. Fixes #1846.
    
    Discussion
    ----------
    
    [HttpFoundation] Remove Content-Length header adding for now. Fixes #1846.
    fabpot committed Aug 13, 2011