Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

fix: bar label for many bars and long labels #21

Merged
merged 3 commits into from Mar 18, 2019
Merged

fix: bar label for many bars and long labels #21

merged 3 commits into from Mar 18, 2019

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented Mar 15, 2019

馃弳 Enhancements

  • Truncate bar label at 40 characters.
  • Add more bottom padding.
  • Ensure the container width and height from parent is applied.
  • Address Airbnb's PRODUCT-57973

Before

image

After

image

@kristw kristw requested a review from a team as a code owner March 15, 2019 23:33
@kristw kristw added #bug Something isn't working reviewable labels Mar 15, 2019
@kristw kristw merged commit 8b9c10a into master Mar 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--bar-label branch March 18, 2019 06:28
@john-wormington-sp john-wormington-sp mentioned this pull request Apr 29, 2019
Closed
3 tasks
nytai referenced this pull request in preset-io/superset-ui-plugins Apr 27, 2020
@kristw
Add generator-superset (#21)
8968cbc 
* add generator to monorepo

* Squash all attempts (+21 squashed commits)
Squashed commits:
[cca27ae] enable jest projects
[e7dc4ce] wip
[dd3ea7a] run in order
[cf87275] define projects
[69baf16] use specific version
[c880cfa] ignore generator test
[e9e0fd3] update travis
[4bbb3c0] update travis
[d63118b] update travis config
[267fe08] remove config
[44883e8] update travis
[40580c3] reduce node version
[59b6add] update ignore rule
[fbbd03c] update readme
[b299dfe] remove script
[a988933] fix test and lint
[95b7d5b] try install and not install
[f4583b4] remove unnecessary files
[c735329] remove eslint-config-xo
[49b3106] pass lint and test
[56c6def] remove git and readd

* can get test to pass if exclude generator-superset

* add afterall to correct working directory

* update config

* add readme
nytai referenced this pull request in preset-io/superset-ui-plugins Apr 27, 2020
@kristw
fix: bar label for many bars and long labels (#21)
97a35dd 
* fix: labels for many bars in bar chart

* fix: nvd3 bar labels

* docs: update example
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
#bug Something isn't working reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristw @williaster