diff --git a/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js b/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js index b8ea18f36c..98a737f171 100644 --- a/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js +++ b/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js @@ -619,6 +619,17 @@ function nvd3Vis(element, props) { .selectAll('.nv-point') .style('stroke-opacity', 1) .style('fill-opacity', 1); + + // redo on legend toggle; nvd3 calls the callback *before* the line is + // drawn, so we need to add a small delay here + chart.dispatch.on('stateChange', () => { + setTimeout(() => { + svg + .selectAll('.nv-point') + .style('stroke-opacity', 1) + .style('fill-opacity', 1); + }, 10); + }); } if (chart.yAxis !== undefined || chart.yAxis2 !== undefined) { diff --git a/plugins/superset-ui-plugins/packages/superset-ui-plugins-demo/storybook/stories/legacy-preset-chart-nvd3/Line/Stories.jsx b/plugins/superset-ui-plugins/packages/superset-ui-plugins-demo/storybook/stories/legacy-preset-chart-nvd3/Line/Stories.jsx index e18820c3c6..64147cafdc 100644 --- a/plugins/superset-ui-plugins/packages/superset-ui-plugins-demo/storybook/stories/legacy-preset-chart-nvd3/Line/Stories.jsx +++ b/plugins/superset-ui-plugins/packages/superset-ui-plugins-demo/storybook/stories/legacy-preset-chart-nvd3/Line/Stories.jsx @@ -39,4 +39,39 @@ export default [ storyName: 'Basic', storyPath: 'legacy-|preset-chart-nvd3|LineChartPlugin', }, + { + renderStory: () => ( + + ), + storyName: 'Markers', + storyPath: 'legacy-|preset-chart-nvd3|LineChartPlugin', + }, ]; diff --git a/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/transformProps.js b/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/transformProps.js index bad42f9368..d9cd8f0a47 100644 --- a/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/transformProps.js +++ b/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/transformProps.js @@ -4,17 +4,8 @@ import { getTimeFormatter } from '@superset-ui/time-format'; /* eslint-disable sort-keys */ export default function transformProps(chartProps) { - const { width, height, datasource = {}, formData, payload } = chartProps; - const { verboseMap = {} } = datasource; - const { - colorScheme, - groupby, - metrics, - xAxisLabel, - xAxisFormat, - yAxisLabel, - yAxisFormat, - } = formData; + const { width, height, formData, payload } = chartProps; + const { colorScheme, xAxisLabel, xAxisFormat, yAxisLabel, yAxisFormat } = formData; return { data: payload.data,