Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

build: suppress logs from intentionally thrown/caught errors #221

Merged
merged 1 commit into from Sep 5, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 4, 2019

馃彔 Internal

Allow suppressing error boundary logs from intentionally thrown/caught errors.
These are caused by default behavior of jsdom and pollute the test report.

This PR adopts solution from this thread to clean up the test report.
facebook/react#11098

@kristw kristw requested a review from a team as a code owner September 4, 2019 17:44
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #221   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         130    130           
  Lines        1416   1416           
  Branches      358    358           
=====================================
  Hits         1416   1416

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 539f9ae...786cd25. Read the comment docs.

@netlify
Copy link

netlify bot commented Sep 4, 2019

Deploy preview for superset-ui ready!

Built with commit 786cd25

https://deploy-preview-221--superset-ui.netlify.com

@kristw kristw added the reviewable Ready for review label Sep 4, 2019
@kristw kristw merged commit 6661bcd into master Sep 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--react branch September 5, 2019 17:27
kristw pushed a commit that referenced this pull request Apr 17, 2020
Bumps [@vx/scale](https://github.com/hshoff/vx) from 0.0.190 to 0.0.192.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.190...v0.0.192)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reviewable Ready for review size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants