Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added search functionality to Accumulo website #81

Merged
merged 1 commit into from May 4, 2018
Merged

Added search functionality to Accumulo website #81

merged 1 commit into from May 4, 2018

Conversation

mikewalch
Copy link
Member

  • Search results are limited to blog posts, release notes, and
    documentation for one Accumulo release
  • Search is implemented in browser using javascript and lunarjs

@mikewalch
Added search functionality to Accumulo website
cfb37f0 
* Search results are limited to blog posts, release notes, and
  documentation for one Accumulo release
* Search is implemented in browser using javascript and lunarjs
milleruntime
milleruntime approved these changes May 4, 2018
View reviewed changes
Copy link
Contributor

@milleruntime milleruntime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@milleruntime
Copy link
Contributor

milleruntime commented May 4, 2018 •
edited

Oh forgot to say... I pulled down your changes and built the website locally. Looks good.

@mikewalch mikewalch merged commit b360e4c into apache:master May 4, 2018
@mikewalch mikewalch deleted the docs-search branch May 4, 2018 19:08
asfgit pushed a commit that referenced this pull request May 4, 2018
@mikewalch
Jekyll build from master:b360e4c
75c1351 
Added search functionality to Accumulo website (#81)

* Search results are limited to blog posts, release notes, and
  documentation for one Accumulo release
* Search is implemented in browser using javascript and lunarjs
@ctubbsii
Copy link
Member

ctubbsii commented May 4, 2018

Search button doesn't work when clicked, and menu option messes with the resize to narrow (mobile) screen widths. Could fix the screen resize by replacing "Apache Software Foundation" words with small feather logo as a button (leaving the adjacent drop-down arrow indicator).

@ctubbsii
Copy link
Member

ctubbsii commented May 6, 2018

Saw that you fixed the button and the resize using Apache feather logo. Great work! Thanks!
I do think we probably should avoid the older feather logo in favor of a newer one, if we can find one that looks okay there.

I also noticed a weird thing with the search implementation... it looks like "No results" are returned for "the", but "th" and even "t" return results. This doesn't make much sense to me. If a stop word isn't indexed, then any substring of the stop word should also not be indexed. Meh, whatever. It's pretty good as is.

@mikewalch mikewalch mentioned this pull request May 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milleruntime milleruntime milleruntime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikewalch @milleruntime @ctubbsii