Admin Fate list command should ignore "no node" exceptions

[ddanielr]

Describe the bug
The admin list command first gets a list of all fate tx ids, then starts to query for specific information.
When a large number of fate transactions are present, the fate command will error on "no node exceptions" because that fate transaction ID has since completed.

This blocks the entire fate list from being printed

Versions (OS, Maven, Java, and others, as appropriate):

• Affected version(s) of this project: [e.g. 1.10.0] 2.1.x
• OS: [e.g. CentOS 7.5] Centos 7
• Others:

Expected behavior
The list command should not fail on fate transactions that are no longer present in ZK.

[ddanielr]

This section of the code could be moved under a try/catch loop for zk lookup failures.

accumulo/core/src/main/java/org/apache/accumulo/core/fate/AdminUtil.java

Lines 343 to 376 in 7c6572c

	for (Long tid : transactions) {
	zs.reserve(tid);
	String txName = (String) zs.getTransactionInfo(tid, Fate.TxInfo.TX_NAME);
	List<String> hlocks = heldLocks.remove(tid);
	if (hlocks == null) {
	hlocks = Collections.emptyList();
	}
	List<String> wlocks = waitingLocks.remove(tid);
	if (wlocks == null) {
	wlocks = Collections.emptyList();
	}
	String top = null;
	ReadOnlyRepo<T> repo = zs.top(tid);
	if (repo != null) {
	top = repo.getName();
	}
	TStatus status = zs.getStatus(tid);
	long timeCreated = zs.timeCreated(tid);
	zs.unreserve(tid, 0, TimeUnit.MILLISECONDS);
	if (includeByStatus(status, filterStatus) && includeByTxid(tid, filterTxid)) {
	statuses.add(new TransactionStatus(tid, status, txName, hlocks, wlocks, top, timeCreated));
	}
	}

[ddanielr]

See if the -s path in the code bypasses this error.

[kevinrr888]

I can work on this

[kevinrr888]

No, the -s path would not bypass the error as the filtering is done after the transaction info is obtained (or attempted to be obtained).

[dlmarion]

Closed by the merge of #4556