Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log waits beyond a threshold in FileManager.reserveReaders() #978

Closed
FineAndDandy opened this issue Feb 22, 2019 · 2 comments

Comments

@FineAndDandy
Copy link
Contributor

commented Feb 22, 2019

While calling FileManager.reserveReaders() filePermits.acquireUninterruptibly(files.size()) is called. This method will block until the filePermits are available. Using tryAcquire(int, long, TimeUnit) in a loop until successful would allow logging beyond a configurable threshold while waiting.

@keith-turner

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

In addition to logging, could also have metrics ... see #946

FineAndDandy added a commit to FineAndDandy/accumulo that referenced this issue Feb 22, 2019

keith-turner added a commit that referenced this issue Feb 26, 2019

@FineAndDandy

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

closed via #981

@ctubbsii ctubbsii added this to To do in 2.0.0 via automation Jun 14, 2019

@ctubbsii ctubbsii moved this from To do to Done in 2.0.0 Jun 14, 2019

@ctubbsii ctubbsii added this to To do in 1.9.3 via automation Jun 14, 2019

@ctubbsii ctubbsii moved this from To do to Done in 1.9.3 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.