Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore exception handling #949 #1005 #1057

Merged
merged 1 commit into from Mar 26, 2019

Conversation

@keith-turner
Copy link
Contributor

commented Mar 26, 2019

This change restores the exception handling in TabletServerLogger to the way it was before the changes in #1005. This changes makes TabletServerGivesUpIT pass.

@keith-turner keith-turner force-pushed the keith-turner:accumulo-949 branch from b7c617e to 6f2ae9a Mar 26, 2019

@keith-turner keith-turner changed the title restore exception handling #949 #1055 restore exception handling #949 #1005 Mar 26, 2019

@ctubbsii

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

@keith-turner Is this intended to block 1.9.3 or should that be labeled 1.9.4? (In other words, are you voting -1 on the 1.9.3 RC1 for this issue?)

@keith-turner

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@ctubbsii I voted -1 on 1.9.3 RC1 because of this issue.

} catch (InterruptedException ex) {
// ignore
}

This comment has been minimized.

Copy link
@milleruntime

milleruntime Mar 26, 2019

Contributor

It looks like this was added back but just in a different place?

This comment has been minimized.

Copy link
@keith-turner

keith-turner Mar 26, 2019

Author Contributor

The code was restructured from one try/catch block into two try/catch blocks. The original try/catch had this, but the two new ones did not.

@keith-turner keith-turner merged commit e93cb7a into apache:1.9 Mar 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@keith-turner keith-turner deleted the keith-turner:accumulo-949 branch Mar 26, 2019

@ctubbsii ctubbsii added this to Done in 1.9.3 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.