Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures correct use of ZooKeeper getAcl #1185

Merged
merged 1 commit into from Jun 7, 2019

Conversation

4 participants
@ctubbsii
Copy link
Member

commented Jun 6, 2019

This fixes a bug in Accumulo where we were using an unauthenticated
ZooKeeper session to read ACLs on a node that we had previously written.

ZooKeeper 3.4.14 fixed a bug in their code that allowed unauthenticated
connections to read ACLs on paths for which they did not have READ
permission.

Using Accumulo with that version of ZooKeeper exposed the bug in our
code that passed the incorrect ZooKeeper session when retrieving ACLs.

Ensures correct use of ZooKeeper getAcl
This fixes a bug in Accumulo where we were using an unauthenticated
ZooKeeper session to read ACLs on a node that we had previously written.

ZooKeeper 3.4.14 fixed a bug in their code that allowed unauthenticated
connections to read ACLs on paths for which they did not have READ
permission.

Using Accumulo with that version of ZooKeeper exposed the bug in our
code that passed the incorrect ZooKeeper session when retrieving ACLs.

@ctubbsii ctubbsii added v2.0.0 labels Jun 6, 2019

@ctubbsii ctubbsii self-assigned this Jun 6, 2019

@ctubbsii ctubbsii requested review from keith-turner and joshelser Jun 6, 2019

@ctubbsii

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

All ITs pass using ZooKeeper 3.4.14.

@joshelser
Copy link
Member

left a comment

Good find! Thanks for the review ping.

@ctubbsii ctubbsii merged commit 3311218 into apache:1.9 Jun 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ctubbsii ctubbsii deleted the ctubbsii:fix-zk-getAcl-without-auths branch Jun 7, 2019

asfgit pushed a commit that referenced this pull request Jun 7, 2019

@ctubbsii ctubbsii added this to Done in 1.9.4 Jun 14, 2019

@ctubbsii ctubbsii added this to Done in 2.0.0 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.