Skip to content

Drop old Map Reduce code #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2022
Merged

Drop old Map Reduce code #2443

merged 5 commits into from
Nov 8, 2022

Conversation

milleruntime
Copy link
Contributor

No description provided.

ctubbsii
ctubbsii reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I think you've already moved any old tests to the new M/R framework, but it's possible there could be some that were missed. This would be good to get into 3.0.

@milleruntime
Copy link
Contributor Author

I think you've already moved any old tests to the new M/R framework, but it's possible there could be some that were missed.

I moved MapReduceIT in this PR. There are 2 other ITs that had tests that I dropped: SslIT and SslWithClientAuthIT. I made an attempt to migrate them to MapReduceIT since they were just calling the runTest method in that IT. But I couldn't get the SSL to work with MapReduceIT and wasn't sure if it was worth the effort.

@ctubbsii
Copy link
Member

ctubbsii commented Nov 8, 2022

I merged main into this to resolve conflicts, and am marking it ready for review. I'm not sure what else needs to be done for this, but that can be ironed out in the review.

@ctubbsii ctubbsii marked this pull request as ready for review November 8, 2022 15:45
ctubbsii
ctubbsii approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for full ITs before merging, but looks good after updating to main.

@ctubbsii
Copy link
Member

ctubbsii commented Nov 8, 2022

Full ITs passed.

@ctubbsii ctubbsii merged commit b546b51 into apache:main Nov 8, 2022
@ctubbsii ctubbsii added this to the 3.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctubbsii ctubbsii ctubbsii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@milleruntime @ctubbsii