Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated replication #3080

Merged
merged 9 commits into from
Nov 30, 2022
Merged

Conversation

ctubbsii
Copy link
Member

This is a work in progress

@ctubbsii ctubbsii self-assigned this Nov 16, 2022
@ctubbsii
Copy link
Member Author

This would remove a little less than 5% of our lines of code, but would still need follow on work to remove the replication table when upgrading from an earlier version.

@cshannon cshannon self-requested a review November 16, 2022 17:07
@ctubbsii ctubbsii marked this pull request as ready for review November 17, 2022 12:49
@ctubbsii
Copy link
Member Author

All ITs passed with these changes

Copy link
Contributor

@jmark99 jmark99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any issues with the changes. LGTM.

Copy link
Contributor

@cshannon cshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, the only comment I had I made earlier about maybe removing the deprecated methods in Mutation vs the UnsupportedOperationException.

@ctubbsii
Copy link
Member Author

Found another flaky SASL/Kerberos test (ThriftTransportKeyTest) due to JVM reuse, just like in #3074 . Running it in a separate JVM seems to fix it. It's not related to these changes, but needed to isolate it to get it to reliably pass the tests in GitHub Actions. I'm still not sure the underlying actual issue with Hadoop's UserGroupInformation that is causing these, but UserGroupInformation.initializedoesn't seem to like being called twice in the same JVM, and assignment to one particular JVM or another by the surefire plugin seems to be flaky, based on environmental conditions.

@ctubbsii ctubbsii merged commit 9bbde86 into apache:main Nov 30, 2022
@ctubbsii ctubbsii deleted the remove-replication branch November 30, 2022 01:01
asfgit pushed a commit that referenced this pull request Aug 14, 2023
* Bump ZK to 3.8.2 patch release
* Backport test/build improvements from #3074 and #3080
* Include updates to post vote checklist GitHub issue template from main
  branch to reduce differences (has no effect on branches other than
  main)
@ctubbsii ctubbsii added this to the 3.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants