-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated replication #3080
Conversation
This would remove a little less than 5% of our lines of code, but would still need follow on work to remove the replication table when upgrading from an earlier version. |
All ITs passed with these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see any issues with the changes. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me, the only comment I had I made earlier about maybe removing the deprecated methods in Mutation vs the UnsupportedOperationException.
Found another flaky SASL/Kerberos test (ThriftTransportKeyTest) due to JVM reuse, just like in #3074 . Running it in a separate JVM seems to fix it. It's not related to these changes, but needed to isolate it to get it to reliably pass the tests in GitHub Actions. I'm still not sure the underlying actual issue with Hadoop's UserGroupInformation that is causing these, but |
This is a work in progress