Decompose tablet thrift svcs main #3107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broke thriftserver.thrift into services that handle scan, ingest and management of tablets. thriftserver.thrift remains and contains tablet server specific APIs.
|
Full IT build succeeded |
ctubbsii
reviewed
Dec 7, 2022
...rc/main/java/org/apache/accumulo/core/rpc/clients/TabletIngestClientServiceThriftClient.java
Show resolved
Hide resolved
|
@ctubbsii - did you want to review this further? I'm thinking we should merge this sooner rather than later. FWIW, I ran a full IT build last night again and it succeeded. |
Delayed response. No. You addressed all the things I had comments on. Thanks 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decompose tabletserver.thrift into multiple files that contain more targeted services (scan, ingest, tablet management, and tablet server).