Skip to content

Clean up deprecated Constraint API #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2022
Merged

Clean up deprecated Constraint API #3116

merged 2 commits into from
Dec 14, 2022

Conversation

cshannon
Copy link
Contributor

@cshannon cshannon commented Dec 9, 2022

Issue #3115

@cshannon cshannon force-pushed the accumulo-3115-contraint branch from 480b4b2 to 13a464c Compare December 9, 2022 17:58
@cshannon cshannon force-pushed the accumulo-3115-contraint branch from 13a464c to 7fa6c80 Compare December 9, 2022 17:59
@cshannon cshannon mentioned this pull request Dec 9, 2022
Closed
3 tasks
ctubbsii
ctubbsii approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern about this is that on upgrade, users will get errors if they had configured a table with the deprecated constraint and have not yet migrated to its replacement. I think this is fine, with sufficient notice in the release notes.

@cshannon
Copy link
Contributor Author

My main concern about this is that on upgrade, users will get errors if they had configured a table with the deprecated constraint and have not yet migrated to its replacement. I think this is fine, with sufficient notice in the release notes.

Sounds good, we can include it in the release notes or upgrade guid as with 3.0 being a major version upgrade I also figured we'd have an upgrade guide with plenty of detail and we can make note of all the deprecated things that were removed.

@cshannon cshannon merged commit 9b7688e into apache:main Dec 14, 2022
cshannon added a commit to cshannon/accumulo that referenced this pull request Dec 17, 2022
@cshannon
Remove test that uses the deprecated Constraint api
806dd2c 
Constraint api was removed in apache#3116
cshannon added a commit to cshannon/accumulo that referenced this pull request Dec 17, 2022
@cshannon
Remove test and jar that uses the deprecated Constraint api
8865900 
Constraint api was removed in apache#3116
@cshannon cshannon mentioned this pull request Dec 17, 2022
Merged
ctubbsii pushed a commit that referenced this pull request Dec 17, 2022
@cshannon
Remove test and jar that uses the deprecated Constraint api (#3133)
bd176df 
Constraint api was removed in #3116
@cshannon cshannon deleted the accumulo-3115-contraint branch March 17, 2023 17:49
@ctubbsii ctubbsii added this to the 3.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctubbsii ctubbsii ctubbsii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cshannon @ctubbsii