remove upgrade code for versions before 2.1 #3160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed this as a draft for comments - still want to double check for unnecessary tests and code that may no longer be references, but this does remove most of the previous upgrade code as is. |
|
This will resolve #3098 |
dlmarion
approved these changes
Jan 25, 2023
ctubbsii
requested changes
Jan 25, 2023
server/base/src/main/java/org/apache/accumulo/server/AccumuloDataVersion.java
Show resolved
Hide resolved
server/base/src/test/java/org/apache/accumulo/server/ServerContextTest.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeChecker.java
Outdated
Show resolved
Hide resolved
added 3 commits
January 25, 2023 23:39
ctubbsii
requested changes
Feb 6, 2023
server/base/src/main/java/org/apache/accumulo/server/AccumuloDataVersion.java
Outdated
Show resolved
Hide resolved
server/base/src/main/java/org/apache/accumulo/server/AccumuloDataVersion.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java
Outdated
Show resolved
Hide resolved
…ataVersion.java Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
…ataVersion.java Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
…de/UpgradeCoordinator.java Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
ctubbsii
previously approved these changes
Feb 7, 2023
ctubbsii
reviewed
Feb 7, 2023
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java
Outdated
Show resolved
Hide resolved
ctubbsii
dismissed
their stale review
The extra check doesn't seem like it would work the way it is intended.
ctubbsii
requested changes
Feb 7, 2023
ctubbsii
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.x will only support upgrades from 2.1, these changes remove code that supports upgrade before 2.1